| davidedmundson |
| Plasma: Design | |
| Plasma |
I reduced so that it looks better on my screen. I cannot try on HDPI ...
What I would like to do as well is:
Both seem to be done by the theme, so no idea where to look.
| Lint Skipped |
| Unit Tests Skipped |
Can you post a screenshot of before/after?
For future reference - any review request that touches the UI should always be accompanied by a screenshot ;)
the reduced calender size in the widget is way better than before, but what's with the text (time) in the panel? the time height in the panel should be the same height than the system tray icon
The calendar popup size is fine for me (with patched plasma-framework), what I *still* think is broken is the gridSize scaling - see https://git.reviewboard.kde.org/r/125773/
You can also test it simply by switching font to DejaVu Sans.
This is because on the "before" i use plasmashell from my distrib, "after" compiled from myself and the latter has font issues.
True, I haven't see that. Sh*t!
Anyway, it's really too big ATM. it takes more than half of my screen, with huge fonts: it's ridiculous I think.
I can work on this, but I'll need some pointers on what and where to change things.
many want to be able to keep the calendar open when doing something else, ie if you want to have a calendar at hand if you are talking with someone in a chat planning for stuff.
in kde4 times we initially had both normal click anywhere to dismiss and we had terrible feedback, until we had to change to make it stay there (and of course group #2 that wanted the opposite thing went out with torches and pitchforks)
but angry mobs aside, both use cases make sense, so the pin is here to stay.
Olivier, have you tried David's suggestion^? Does it make any difference? I also think the patch mentioned above should be in.
Changing the font to DejaVuSans only changes the time font, but not the calendar one.
I'll try his patch.
-1, the calendar is only going to look more cramped like this.
Whitespace is useful and part of the visual language, don't just remove it.
Also, the size of the calendar is oriented with the size of the systray popup, this change will make it inconsistent, and making the systray popup smaller is not an option since it's already pretty densely populated (e.g. networkmanager, bluetooth don't looked especially spacious).
But it takes more than half of my screen !!! I tend to think it should follow the size of the panel, but this is more work
Well, it depends on font size plus whitespace.
All the screens I've used are fine, btw, but for smaller screens, it may look a bit larger.
Once it carries events, it will make better use of that space, anyway.
But it takes more than half of my screen !!!
Yes, because gridUnit sizing is broken. Here is how it looks on my system with patched plasma-framework:
But it takes more than half of my screen !!!
Yes, because gridUnit sizing is broken. Here is how it looks on my system with patched plasma-framework:
This size looks fine.
@sebas: just for info, is here my panel config:
[PlasmaViews][Panel 97][Horizontal1366]
length=1164
thickness=24
the thickness is very small, and changing the font *does not* change the font in the calendar.
@ochurlaud You're sure? The QGuiApplication::font() is the base for all sizing. Did you change the font, or the font size? (It could be that the fonts you've tried have similar metrics.)
So just to show exactly my issue:
Other applets are very fine! but look at the font size difference between the clock and the different parts of the calendar.
I think on big screens it's good but not for people with 14'' screens... 1366x768...
