applets/kicker/plugin/actionlist.cpp
256	This should be done in applets/kicker/plugin/kastatsfavoritesmodel.cpp as well line 162 and line 275. I have a patch ready @broulik I can take over if you'd like.

@meven Yes, please do. Thanks.

meven commandeered this revision.Oct 17 2019, 12:59 PM

meven added a reviewer: broulik.

Use QDir::isAbsolutePath and rebase

meven retitled this revision from Accept local paths to Refactor code for better correctness.Oct 17 2019, 1:06 PM

meven edited the summary of this revision. (Show Details)

meven edited the test plan for this revision. (Show Details)

meven retitled this revision from Refactor code for better correctness to Ensure url from KActivity resources are properly built.

amend commit message

ivan added inline comments.

applets/taskmanager/plugin/backend.cpp
321–324	`resultIt->resource()` (when you are at it :) )

Avoid an unnecessary dereference

meven marked an inline comment as done.

This revision is now accepted and ready to land.Jan 24 2020, 9:00 PM

After further check, my patch does not do much, just allowed me to discover bug about dolphin's recent folder list missing.

if (QDir::isAbsolutePath(resource)) {
    resource = QUrl::fromLocalFile(resource).toString();
}

Here QDir::isAbsolutePath will always be true because at line 312 | Url::file(); we requested files only.

Same is true for D24728

applets/taskmanager/plugin/backend.cpp
335	This prevents filemanager (or apps that opens dirs) to display their recent directories will fix. Same goes in D24728.

Revision Contents
Changeset List

			Path	Packages
M			applets/kicker/plugin/actionlist.cpp (5 lines)
M			applets/taskmanager/plugin/backend.cpp (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	60372			Jun 22 2019, 4:00 PM	★	★
Diff 2	68127	a0c0abb	Use QDir::isAbsolutePath and rebase	Oct 17 2019, 12:59 PM	★	★
Diff 3	68132	a0c0abb	amend commit message	Oct 17 2019, 1:14 PM	★	★
Diff 4	68193	a0c0abb	Avoid an unnecessary dereference	Oct 17 2019, 7:02 PM	★	★

Ensure url from KActivity resources are properly builtAbandonedPublicActions