Split ksmserver into a small application that handles startup and ksmserver
ClosedPublic

Authored by davidedmundson on Jun 22 2019, 12:41 PM.

Details

Summary

This allows new startup procedures to use a session manager and also
allows us to slowly replace the session manager without breaking plasma.

Following on from the previous refactor, Startup and Shutdown are moved
from kmserver and the previous calls into KSMserver are replaced with
DBus calls.

Somewhat depends on D19389, but patched to allow separate testing

Test Plan

Logged in

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Plasma. · View Herald TranscriptJun 22 2019, 12:41 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Jun 22 2019, 12:41 PM
bshah added a subscriber: bshah.Jun 22 2019, 12:52 PM
bshah added inline comments.
startkde/waitforname/CMakeLists.txt
8 ↗(On Diff #60340)

?

davidedmundson marked an inline comment as done.

Update merge issue

davidedmundson added inline comments.Jun 22 2019, 1:45 PM
startkde/plasma-session/shutdown.cpp
67–73

This code is ready, just commented out due to waiting on libkworkspace2

Commented out to allow for testing without making them dependent.

apol added a subscriber: apol.Jun 23 2019, 9:08 AM
apol added inline comments.
ksmserver/server.h
56

?

startkde/plasma-session/startup.cpp
418

watcher->deleteLater();

davidedmundson added inline comments.Jun 23 2019, 9:11 AM
startkde/plasma-session/startup.cpp
418

It's a QDbusServiceWatcher not a QDBusPendingCallWatcher

it's parented to the job which will quit

davidedmundson marked an inline comment as done.

whitespace

Reset state when told to resume an empty session

apol accepted this revision.Jul 9 2019, 10:48 PM

Let's do this!

This revision is now accepted and ready to land.Jul 9 2019, 10:48 PM
This revision was automatically updated to reflect the committed changes.