Differential D21763

[kcms/ksmserver] Port to new kworkspace API
ClosedPublic
Actions

Authored by davidedmundson on Jun 12 2019, 10:45 AM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R119:4e2db5dc02a2: [kcms/ksmserver] Port to new kworkspace API
Summary

requestShutDown is replaced

Test Plan

Bodged the code so that it made my system think it had firmware support
Clicked checkbox, pressed button. Got my shutdown prompt

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Plasma. · View Herald TranscriptJun 12 2019, 10:45 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Jun 12 2019, 10:45 AM
davidedmundson updated this revision to Diff 59929.Jun 16 2019, 3:46 PM

update enum -> enum class

broulik accepted this revision.Jun 21 2019, 4:36 PM
broulik added a subscriber: broulik.
broulik added inline comments.
kcms/ksmserver/kcmsmserver.cpp
86

Coding style.

88

Is this safe, or should it do a deleteLater()?

This revision is now accepted and ready to land.Jun 21 2019, 4:36 PM
Closed by commit R119:4e2db5dc02a2: [kcms/ksmserver] Port to new kworkspace API (authored by davidedmundson). · Explain WhyJul 10 2019, 11:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcms/ksmserver/kcmsmserver.cpp (14 lines)

Diff 61555

View Options

kcms/ksmserver/kcmsmserver.cpp

Loading...