Differential D21919

Change joystick settings icon to game controller
ClosedPublic
Actions

Authored by ndavis on Jun 20 2019, 9:47 AM.

Details

Reviewers
ngraham
filipf
Group Reviewers
VDG
Commits
R266:7ef3c35c7ed6: Change joystick settings icon to game controller
Summary

Most of the "joysticks" that people have are game controllers, so a complete controller is better than just a D-pad.

BUG: 406679
FIXED-IN: 5.60

Test Plan

left: old, right: new

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ndavis created this revision.Jun 20 2019, 9:47 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptJun 20 2019, 9:47 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ndavis requested review of this revision.Jun 20 2019, 9:47 AM
ndavis edited the test plan for this revision. (Show Details)Jun 20 2019, 9:49 AM
ndavis edited the summary of this revision. (Show Details)
ngraham accepted this revision.Jun 20 2019, 10:28 AM
This revision is now accepted and ready to land.Jun 20 2019, 10:28 AM
ngraham added a comment.Jun 20 2019, 10:29 AM

Maybe we should also consider renaming the KCM to be "Gaming Controller" since I don't know how many people are actually using standalone joysticks anymore. I remember that those were all the rage in the 90s, but probably these days people are just using their XBox controllers or whatever.

usta added a subscriber: usta.Jun 20 2019, 10:32 AM
In D21919#482275, @ngraham wrote:

Maybe we should also consider renaming the KCM to be "Gaming Controller" since I don't know how many people are actually using standalone joysticks anymore. I remember that those were all the rage in the 90s, but probably these days people are just using their XBox controllers or whatever.

+1 , at least GamePads or Game Controllers

filipf accepted this revision.Jun 20 2019, 10:54 AM
ngraham added a comment.Jun 20 2019, 10:58 AM

Looks like that's done in D21922

Closed by commit R266:7ef3c35c7ed6: Change joystick settings icon to game controller (authored by ndavis). · Explain WhyJun 20 2019, 11:46 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 60113

View Options

icons-dark/preferences/32/preferences-desktop-gaming.svg

Loading...
View Options

icons/preferences/32/preferences-desktop-gaming.svg

Loading...