Differential D21623

[ToolButton] Pass custom icon size to StyleItem
ClosedPublic
Actions

Authored by broulik on Jun 6 2019, 3:15 PM.

Details

Reviewers
mart
davidedmundson
filipf
Group Reviewers
Plasma
Commits
R858:e98728c7667a: [ToolButton] Pass custom icon size to StyleItem
Summary

Follow up on D20418. Not sure what I was testing back then but it clearly couldn't have worked. Maybe I just forgot to add this part to the diff.

Test Plan

icon.width and icon.height on a ToolButton now work

Diff Detail

Repository
R858 Qt Quick Controls 2: Desktop Style
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jun 6 2019, 3:15 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 6 2019, 3:15 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jun 6 2019, 3:15 PM
filipf added a subscriber: filipf.Jun 6 2019, 3:36 PM
davidedmundson accepted this revision.Jun 6 2019, 4:15 PM
This revision is now accepted and ready to land.Jun 6 2019, 4:15 PM
Closed by commit R858:e98728c7667a: [ToolButton] Pass custom icon size to StyleItem (authored by broulik). · Explain WhyJun 7 2019, 8:34 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Morg.kde.desktop/ToolButton.qml (2 lines)

Diff 59315

View Options

org.kde.desktop/ToolButton.qml

Loading...