[showdesktop][minimzeall] Reduce the maximum panel icon size
ClosedPublic

Authored by ndavis on Wed, Jun 5, 8:42 AM.

Details

Summary

The current size of the showdesktop/minimzeall widget is much larger than it needs to be. This patch reduces the maximum size in panels to smallMedium (22px).

Test Plan

Before:


After:

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ndavis created this revision.Wed, Jun 5, 8:42 AM
Restricted Application added a project: Plasma. · View Herald TranscriptWed, Jun 5, 8:42 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ndavis requested review of this revision.Wed, Jun 5, 8:42 AM
ndavis edited the test plan for this revision. (Show Details)Wed, Jun 5, 8:48 AM

This also needs to be applied to the minimizeall widget, as this is the directly (right click) selectable alternative to showdesktop widget, so the icon size change would revert if a user switched the panel widget to this.

broulik added a subscriber: broulik.Wed, Jun 5, 9:08 AM

While I'm all for making the show desktop icon stick out less I don't think randomly limiting the size of one particular applet is a good approach. The iconSizeHints is there for a reason, defining the maximum size of icons in the panel.

ndavis added a comment.Wed, Jun 5, 9:14 AM

While I'm all for making the show desktop icon stick out less I don't think randomly limiting the size of one particular applet is a good approach. The iconSizeHints is there for a reason, defining the maximum size of icons in the panel.

The problem with the panel size hint is if you want a small showdesktop icon, you also get a small application launcher icon.

ndavis added a comment.Wed, Jun 5, 9:14 AM

This also needs to be applied to the minimizeall widget, as this is the directly (right click) selectable alternative to showdesktop widget, so the icon size change would revert if a user switched the panel widget to this.

I'll be sure to do that one as well then.

ndavis updated this revision to Diff 59181.Wed, Jun 5, 9:28 AM

Add changes to minimizeall as well

ngraham added a subscriber: ngraham.Wed, Jun 5, 1:25 PM

Did the approach of twiddling with the icons not work?

ndavis added a comment.Wed, Jun 5, 1:35 PM

Did the approach of twiddling with the icons not work?

I couldn't figure out how to make the widget get the icon from the desktop theme, but I thought the showdesktop and minimzeall applets took up too much space anyway.

I couldn't figure out how to make the widget get the icon from the desktop theme

IIRC you have to make it use a PlasmaComponents SVGItem instead of an IconItem (but a Plasma person could confirm)

I thought the showdesktop and minimzeall applets took up too much space anyway.

You're not necessarily wrong, but I do worry that we'll get bug reports where people say, "The Show Desktop item has a small vertically centered icon when the panel is tall"

I couldn't figure out how to make the widget get the icon from the desktop theme

Plasma IconItem primarily uses icons from Plasma theme, if such exists, or told so otherwise by setting usesPlasmaTheme to false

mart accepted this revision.Thu, Jun 6, 11:07 AM
mart added a subscriber: mart.

should be pushed to 5.16 as well

This revision is now accepted and ready to land.Thu, Jun 6, 11:07 AM
ndavis retitled this revision from [showdesktop] Reduce the maximum panel icon size to [showdesktop][minimzeall] Reduce the maximum panel icon size.Thu, Jun 6, 11:08 AM
ndavis edited the summary of this revision. (Show Details)
This revision was automatically updated to reflect the committed changes.

@ndavis in the future, the best way to do this would be to land it on the Plasma/5.16 branch, then merge that branch to master. This process is detailed at https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22