The current size of the showdesktop/minimzeall widget is much larger than it needs to be. This patch reduces the maximum size in panels to smallMedium (22px).
Details
Details
Before:
After:
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Branch
- show-desktop-icon (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 12423 Build 12441: arc lint + arc unit
Comment Actions
This also needs to be applied to the minimizeall widget, as this is the directly (right click) selectable alternative to showdesktop widget, so the icon size change would revert if a user switched the panel widget to this.
Comment Actions
While I'm all for making the show desktop icon stick out less I don't think randomly limiting the size of one particular applet is a good approach. The iconSizeHints is there for a reason, defining the maximum size of icons in the panel.
Comment Actions
The problem with the panel size hint is if you want a small showdesktop icon, you also get a small application launcher icon.
Comment Actions
I couldn't figure out how to make the widget get the icon from the desktop theme, but I thought the showdesktop and minimzeall applets took up too much space anyway.
Comment Actions
IIRC you have to make it use a PlasmaComponents SVGItem instead of an IconItem (but a Plasma person could confirm)
You're not necessarily wrong, but I do worry that we'll get bug reports where people say, "The Show Desktop item has a small vertically centered icon when the panel is tall"
Comment Actions
I couldn't figure out how to make the widget get the icon from the desktop theme
Plasma IconItem primarily uses icons from Plasma theme, if such exists, or told so otherwise by setting usesPlasmaTheme to false
Comment Actions
@ndavis in the future, the best way to do this would be to land it on the Plasma/5.16 branch, then merge that branch to master. This process is detailed at https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22