| bruns | |
| dfaure | |
| thiago |
D21155 trucates a QString. Since most Linux FS specify filename limits in bytes, convert the url to
QByteArray and then truncate.
As for truncating a UTF-8 sequence in middle, will it have any noticeable impact?
After truncating, the url loses any meaning it had initially. So IMO a few characters
at the end which were initially not a part of the url don't make any difference.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
+1 from me, but if Thiago can take a look (about the issue of truncating in the middle of a multi-bytes utf8 characters) that'd be even better.
I cringe a little when you apply QFile to a URL, but this is probably safe enough.
LGTM
As for truncating UTF-8 multibyte sequences in the middle, when you convert back using QFile::decodeName, it'll be nonsensical. But I don't think it really matters since you're truncating and using the display string anyway, so you're already losing data. This wasn't a recoverable conversion anyway.