| elvisangelaccio | |
| GB_2 |
| VDG |
The Filter combobox currently always has the label "Filter:" This is appropriate in most
cases, but becomes inaccurate when saving with a limited list of mimetypes. In this case,
the combobox loses its text field and becomes a file type chooser rather than a filter.
This patch changes the label to "File type:" for that use case.
BUG: 79903
FIXED-IN: 5.59
Opening a file: no changes
Saving a file with no mimetype filter: no changes
Saving a file with a limited list of mimetypes: label is changed
| No Linters Available |
| No Unit Test Coverage |
| Buildable 11511 | |
| Build 11529: arc lint + arc unit |
| src/filewidgets/kfilewidget.cpp | ||
|---|---|---|
| 739 | Isn't it a bit weird to do this in setMimeFilter? | |
| src/filewidgets/kfilewidget.cpp | ||
|---|---|---|
| 739 | I did it in setMimeFilter since that's where it's determined whether or not there's a limited assortment of mimetypes, which is what controls what the string should be. Conditionalizing it based on mode seemed safe enough considering that there's mode-specific code a few lines above, on 741. | |
| src/filewidgets/kfilewidget.cpp | ||
|---|---|---|
| 739 | ::setOperationMode would need to update that as well, no? Then it would need splitting into a separate function, otherwise | |
Put it in a function and then call that function in all the places where things might change
+1 looks good to me besides the nitpick.
| src/filewidgets/kfilewidget.cpp | ||
|---|---|---|
| 594 | Pass this as parent, I guess when it's added to the layouts somehow it will get reparented, but I'd say it's a good practice. | |
| src/filewidgets/kfilewidget.cpp | ||
|---|---|---|
| 2803–2805 ↗ | (On Diff #57492) | why is this limited to the saving mode? you can perfectly use a mimetype filter when opening files |
| src/filewidgets/kfilewidget.cpp | ||
|---|---|---|
| 2803–2805 ↗ | (On Diff #57492) | When opening, the mimetype chooser still has filtering functionality and isn't a drop-down menu combobox like it is when saving. I couldn't come up with an adequate string to communicate both purposes and figured "Filter" was good enough. |