Rename file dialog "Filter" label text to "Type"
AbandonedPublic

Authored by GB_2 on May 1 2019, 12:16 PM.

Details

Reviewers
elvisangelaccio
Group Reviewers
Frameworks
Plasma
VDG
Summary

BUG: 79903

The term "Filter" is a bit strange for choosing a file type, "File type" sounds better and is more appropriate.

Test Plan

Open any open/save file dialog.

Diff Detail

Repository
R241 KIO
Branch
rename-file-dialog-filter-label-text-to-type (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11401
Build 11419: arc lint + arc unit
GB_2 created this revision.May 1 2019, 12:16 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 1 2019, 12:16 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
GB_2 requested review of this revision.May 1 2019, 12:16 PM
elvisangelaccio requested changes to this revision.May 1 2019, 3:55 PM
elvisangelaccio added a subscriber: elvisangelaccio.

"Filter" is the correct word, you can enter any string in the label (not necessarily a file type) and the view will be filtered accordingly.

This revision now requires changes to proceed.May 1 2019, 3:55 PM
GB_2 abandoned this revision.May 1 2019, 4:46 PM
ngraham added a subscriber: ngraham.May 1 2019, 6:03 PM

Well, it's more complicated than that. It's a filter when it's a text field, but when saving, it can be a combobox for choosing a file type. So it should say "Filter:" when it's a text field, and "File Type:" when it's a combobox.

Submitted a patch that does that: D20964