[Extractor] Move property conversion from external process to calling job
ClosedPublic

Authored by bruns on May 2 2019, 11:26 AM.

Details

Summary

Using integer keys is more compact, and allows to remove the
KFileMetaData::PropertyInfo code from the temporary extractor.

Doing the conversion from integer to QString keys after serialization also
allows shared string data, as it uses the instances from PropertyInfo::name()
instead of inherently non-shared QStrings from deserialization.

Depends on D20956
Depends on D20738

Test Plan

ctest

Diff Detail

Repository
R824 Baloo Widgets
Branch
serialization
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11440
Build 11458: arc lint + arc unit
bruns created this revision.May 2 2019, 11:26 AM
Restricted Application added a project: Baloo. · View Herald TranscriptMay 2 2019, 11:26 AM
bruns requested review of this revision.May 2 2019, 11:26 AM
bruns edited the summary of this revision. (Show Details)May 3 2019, 12:22 AM
astippich accepted this revision.May 3 2019, 5:50 AM

FileMetaDataDateDisplayTest first spew a lot of warnings (but eventually passed?). D19268 missed the DateDisplayTest

This revision is now accepted and ready to land.May 3 2019, 5:50 AM
This revision was automatically updated to reflect the committed changes.
bruns added a comment.May 3 2019, 12:06 PM

FileMetaDataDateDisplayTest first spew a lot of warnings (but eventually passed?). D19268 missed the DateDisplayTest

Good catch, I have added the test and pushed the change.