Move map conversion to common file
ClosedPublic

Authored by astippich on Apr 22 2019, 3:00 PM.

Details

Diff Detail

Repository
R824 Baloo Widgets
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich created this revision.Apr 22 2019, 3:00 PM
Restricted Application added a project: Baloo. · View Herald TranscriptApr 22 2019, 3:00 PM
Restricted Application added a subscriber: Baloo. · View Herald Transcript
astippich requested review of this revision.Apr 22 2019, 3:00 PM
astippich planned changes to this revision.Apr 23 2019, 6:43 AM

missed some stuff for deletion, will cleanup later

astippich updated this revision to Diff 56841.Apr 23 2019, 7:36 PM
  • cleanup

friendly ping for the series

bruns added a comment.Thu, May 2, 11:36 AM

This clashes somewhat with D20956/D20960 code wise, but otherwise fits very nicely with it - i.e. the code has to be moved around, but can be used unchanged otherwise.

I think the best order would be to:

  1. Land D20956
  2. Add toNamedVariantMap(...) to filemetadatautil{.cpp,_p.h} and land it (i.e. this review)
  3. Land D20739 and D20960 (no dependency)
src/propertymaputil_p.h
28 ↗(On Diff #56841)

After D20739, this function is IMHO large enough to not have it inline.

After D20960, both calling sites live in the same process.

Fine with me

astippich updated this revision to Diff 57413.Thu, May 2, 9:02 PM
  • remove now unused includes
bruns accepted this revision.Fri, May 3, 12:02 AM
This revision is now accepted and ready to land.Fri, May 3, 12:02 AM
This revision was automatically updated to reflect the committed changes.