Differential D20834

Remove the padding of the bookmark bar
ClosedPublic
Actions

Authored by trmdi on Apr 26 2019, 4:05 AM.

Details

Reviewers
drosca
Group Reviewers
Falkon
VDG
Commits
R875:935e422926e5: Remove the padding of the bookmark bar
Summary

Remove the padding of the bookmark bar

Test Plan

Breeze widget style:


Fusion widget style:

Diff Detail

Repository
R875 Falkon
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11304
Build 11322: arc lint + arc unit
trmdi created this revision.Apr 26 2019, 4:05 AM
Restricted Application added a project: Falkon. · View Herald TranscriptApr 26 2019, 4:05 AM
Restricted Application added a subscriber: falkon. · View Herald Transcript
trmdi requested review of this revision.Apr 26 2019, 4:05 AM
trmdi edited the test plan for this revision. (Show Details)Apr 26 2019, 4:06 AM
ngraham accepted this revision as: VDG.Apr 26 2019, 3:18 PM
ngraham added a subscriber: ngraham.

+1 for UI. Let's see if the Falkon folks think this is the right way to implement the change.

drosca added a subscriber: drosca.Apr 27 2019, 5:38 AM

Did you test with other Qt styles (fusion, windows, ...) ?

trmdi updated this revision to Diff 57113.Apr 27 2019, 5:11 PM

Remove the padding of the bookmark bar

trmdi edited the summary of this revision. (Show Details)Apr 27 2019, 5:20 PM
trmdi edited the test plan for this revision. (Show Details)
trmdi retitled this revision from Remove the padding of BookmarksToolbarButton to Remove the padding of the bookmark bar.
In D20834#457057, @drosca wrote:

Did you test with other Qt styles (fusion, windows, ...) ?

Yes, it works too.

cullmann added a subscriber: cullmann.Jul 8 2019, 5:23 PM

For me this seems to look nicer, too, is this ok to get it in?

drosca accepted this revision.Jul 12 2019, 2:17 PM
This revision is now accepted and ready to land.Jul 12 2019, 2:17 PM
Closed by commit R875:935e422926e5: Remove the padding of the bookmark bar (authored by trmdi, committed by cullmann). · Explain WhyJul 13 2019, 3:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mthemes/linux/main.css (4 lines)

Diff 57113

View Options

themes/linux/main.css

Loading...