| dfaure | |
| ngraham | |
| davidedmundson | |
| mart |
| VDG | |
| Plasma |
This patch bumps dictionary's settings QtQuickControls from version 1 to 2.
It also changes the configuration category's icon to match the applet's one.
Before:
After:
| No Linters Available |
| No Unit Test Coverage |
| Buildable 11305 | |
| Build 11323: arc lint + arc unit |
Why doesn't mouse wheel scrolling with with ScrollView? That seems odd and unexpected. I would recommend we use that component and figure out why it doesn't work. Also it seems semantically incorrect to be putting a ScrollablePageinside a page. That thing is supposed to be the whole page, not one component of it.
BTW, since while using ScrollView you'll probably run into this, to make a QQC2 ScrollView display its frame, you do this:
QQC2.ScrollView {
Component.onCompleted: background.visible = true;
[blabla]
}Also LOL we really need to fix that broken icon: https://bugs.kde.org/show_bug.cgi?id=399568
Not sure, but will investigate further.
Another issue with the QQC2 ScrollView is that it's also kind of inferior visually :/ . The labels are glued to the frame and the scrollbar just floats on top of everything:
You can add internal padding yourself, and the scrollbar floating above everything is an implementation issue IIRC
make it work with ScrollView and make ScrollView not buggy by using ContentWidth and ContentHeight to allow mouse scrolling, as well as setting clip to true so the scrollbar is actually contained within the view
Err sorry, this is a binding loop monstrosity, I cannot be defining the parent with the children and vice versa at the same time.
Is there some trick to applying this? I don't actually see any change to the dictionary widget's configuration window. I got the same problem when I started working on this myself, so it's not something you did wrong...
Works for me both in the latest Manjaro stable and in KDE Neon unstable. I've been editing /usr/share/plasma/plasmoids/org.kde.plasma_applet_dict/contents/ui/ConfigDictionaries.qml
| applets/dict/package/contents/ui/ConfigDictionaries.qml | ||
|---|---|---|
| 57 ↗ | (On Diff #56927) | Control { which should have the highlight rectangle as background: and the Label as contentItem: this will give it some nice paddings, as now it looks quite cramped |
| 65 ↗ | (On Diff #56927) | Kirigami.Theme.highlightColor |
| 69 ↗ | (On Diff #56927) | Label { |
| 73 ↗ | (On Diff #56927) | Kirigami.Theme.textColor |
| applets/dict/package/contents/ui/ConfigDictionaries.qml | ||
|---|---|---|
| 33 ↗ | (On Diff #56927) | This can be removed when you chang the the other color properties. |
| applets/dict/package/contents/ui/ConfigDictionaries.qml | ||
|---|---|---|
| 57 ↗ | (On Diff #56927) | looks much better, thanks :) |