BUG: 398469
BUG: 408573
Port the KCM to the new GriedView KCM design.
Credits go to @broulik, he basically did all the work.
ngraham | |
broulik |
Plasma | |
VDG |
BUG: 398469
BUG: 408573
Port the KCM to the new GriedView KCM design.
Open the Plymouth Boot Splash Screen KCM.
No Linters Available |
No Unit Test Coverage |
Buildable 10963 | |
Build 10981: arc lint + arc unit |
Neato, thanks!
Bugs I found:
src/kcm.cpp | ||
---|---|---|
88 | Ideally here we would reload the model and then set the newly installed theme as current | |
172 | I think the model population must be split from the KCM load() so you can reload the model without marking it as non-dirty. Right now when installing a new theme, the Apply button doesn't enable and no theme is selected. Ideally it would select the newly installed theme. Also needs a emit selectedPluginIndexChanged(); after reloading the model as a model reset will cause ListView to forget its currentIndex | |
225–228 | In error handling we should probably check for error() == KAuth::ActionReply::UserCancelledError to not show a pointless error message when user canceled | |
226 | This isn't a signal, also why do you need to reload when saving? It's not like any themes could magically appear here? | |
src/kcm.h | ||
76 | I think this should be a property Q_PROPERTY(bool saving...) or more generic busy like in the other KCMs and then proper bindings in the UI | |
src/package/contents/ui/main.qml | ||
66–72 | In all the other KCMs the InlineMessage is above the controls to not push them around as it comes and goes | |
74–80 | I don't think this "progress" bar adds much value |
src/package/contents/ui/main.qml | ||
---|---|---|
74–80 | I think it really does. Otherwise the whole UI freezes for 20 seconds and you think it's died. At least with the progress bar, you know something's happening. |
src/package/contents/ui/main.qml | ||
---|---|---|
74–80 | Ah, it calls update-alternatives internally, alright, that might take some time. |
src/kcm.cpp | ||
---|---|---|
226 | It resets it if you cancel the action, so the apply button is enabled again and the selection is reset. |
@broulik Do you want to commandeer this revision and do the rest?
What is "the rest" ?
src/kcm.cpp | ||
---|---|---|
88 | I think it should not select the newest installed theme instead of still having the current one selected, because in the "Get New..." dialog you can install multiple themes and it can't know which of them you actually want. |
Ping @broulik
I think we should finally land this and make more changes later in case there are only any small issues left.