Depends on D20598
Details
Diff Detail
- Repository
- R120 Plasma Workspace
- Branch
- arcpatch-D20533
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 11036 Build 11054: arc lint + arc unit
applets/batterymonitor/package/contents/ui/batterymonitor.qml | ||
---|---|---|
106 | Typo? kcm_energyinfo vs kcms_energyinfo |
applets/batterymonitor/package/contents/ui/batterymonitor.qml | ||
---|---|---|
106 | Thanks |
I like having it in the context menu. Putting it in the expanded pop-up I'm less sure about, because the icon isn't as recognizable and maybe we might be cluttering the view up too much?
-1 please let's cleanup / rewrite the energy info kcm first using Kirigami FormLayout and kcm components before making it prominently accessible from the UI
applets/batterymonitor/package/contents/ui/batterymonitor.qml | ||
---|---|---|
143 | This should be in a check for kcmEnergyInformationAuthorized |
applets/batterymonitor/package/contents/ui/batterymonitor.qml | ||
---|---|---|
143 | Generally we start menu items with action verbs. And in this case we don't need ellipsis because no further input from the user is required as a part of the action. See https://hig.kde.org/style/writing/labels.html#using-ellipses-in-labels So for this string, I would recommend "Show Energy Information" |
applets/batterymonitor/package/contents/ui/batterymonitor.qml | ||
---|---|---|
143 | Thanks for pointing it out. |
Check the energy information is available before showing a link to it, don't show a link to it from the battery applet
applets/batterymonitor/package/contents/ui/batterymonitor.qml | ||
---|---|---|
143 | Not fixed yet. The text needs to be "Show Energy Information..." |