Differential D20513

Remove last traces of KFileMetaDataWidget from information panel
ClosedPublic
Actions

Authored by bruns on Apr 13 2019, 5:36 PM.

Details

Reviewers
apol
ngraham
elvisangelaccio
Group Reviewers
Frameworks
Dolphin
Commits
R318:05a4d27813e3: Remove last traces of KFileMetaDataWidget from information panel
Summary

The whole information panel is not included when Baloo is not found,
so there is no need for the HAVE_BALOO guards.
KFileMetaDataWidget and KFileMetaDataConfigurationWidget were never part
of KF5, see https://git.reviewboard.kde.org/r/113153/

Test Plan

ctest

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Apr 13 2019, 5:36 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptApr 13 2019, 5:36 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
bruns requested review of this revision.Apr 13 2019, 5:36 PM
ngraham added a comment.Apr 14 2019, 1:46 AM

Won't this close the door on ever being able to implement something like https://bugs.kde.org/show_bug.cgi?id=406506?

Not that the current UX is that great...

bruns added a comment.Apr 14 2019, 3:02 AM
In D20513#449484, @ngraham wrote:

Won't this close the door on ever being able to implement something like https://bugs.kde.org/show_bug.cgi?id=406506?

Not that the current UX is that great...

Baloo in this case means KFileMetaData + baloo-widgets

elvisangelaccio added a subscriber: elvisangelaccio.Apr 14 2019, 11:52 AM
elvisangelaccio added inline comments.
src/panels/information/filemetadataconfigurationdialog.h
35

Can you please also update this comment? It should mention Baloo::FileMetaDataWidget.

bruns marked an inline comment as done.Apr 14 2019, 12:53 PM
bruns updated this revision to Diff 56192.Apr 14 2019, 12:56 PM

remove one more reference in comments

This revision is now accepted and ready to land.Apr 14 2019, 12:57 PM
Closed by commit R318:05a4d27813e3: Remove last traces of KFileMetaDataWidget from information panel (authored by bruns). · Explain WhyApr 14 2019, 12:59 PM
This revision was automatically updated to reflect the committed changes.
bruns added inline comments.Apr 14 2019, 1:00 PM
src/panels/information/filemetadataconfigurationdialog.h
35

Good catch ...

Revision Contents
Changeset List

Diff 56193

View Options

src/panels/information/filemetadataconfigurationdialog.h

Loading...
View Options

src/panels/information/informationpanelcontent.h

Loading...