Don't include same dependency twice, one which was found
from readelf in specifydependencies.cmake and other in
ANDROID_EXTRA_LIBS.
Bug fix: find stl was dependent on the order in which libc++
was added, now it is independent.
Don't include same dependency twice, one which was found
from readelf in specifydependencies.cmake and other in
ANDROID_EXTRA_LIBS.
Bug fix: find stl was dependent on the order in which libc++
was added, now it is independent.
No Linters Available |
No Unit Test Coverage |
Buildable 10874 | |
Build 10892: arc lint + arc unit |
toolchain/ECMAndroidDeployQt.cmake | ||
---|---|---|
41 ↗ | (On Diff #56151) | Please split into a separate patch. |
41 ↗ | (On Diff #56151) | what if it's using an stl version that isn't called .+shared.so? |
toolchain/specifydependencies.cmake | ||
24 ↗ | (On Diff #56151) | I'd call the function contains_library, as is it looks that it's duplicating something. Also pass the output value as an argument instead of magically declaring IS_EQUAL. |
40 ↗ | (On Diff #56151) | It shouldn't be necessary to set it back again. |