Don't include same dependency twice, one which was found
from readelf in specifydependencies.cmake and other in
ANDROID_EXTRA_LIBS.
Bug fix: find stl was dependent on the order in which libc++
was added, now it is independent.
Details
Details
- add the same dependency in ANDROID_EXTRA_LIBS
Diff Detail
Diff Detail
- Repository
- R240 Extra CMake Modules
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 10805 Build 10823: arc lint + arc unit
| toolchain/ECMAndroidDeployQt.cmake | ||
|---|---|---|
| 42 | Please split into a separate patch. | |
| 42 | what if it's using an stl version that isn't called .+shared.so? | |
| toolchain/specifydependencies.cmake | ||
| 24 | I'd call the function contains_library, as is it looks that it's duplicating something. Also pass the output value as an argument instead of magically declaring IS_EQUAL. | |
| 40 | It shouldn't be necessary to set it back again. | |