Add "What's This?" to nearly everything in the main window
Needs ReviewPublic

Authored by felixernst on Apr 11 2019, 3:44 PM.

Details

Reviewers
elvisangelaccio
Group Reviewers
Dolphin
Summary

This commit adds "What's This?" help to nearly everything in the
Dolphin main window (panels, views, buttons, ...). It adds the "?"
to the title bar so this help can easily be called.

For links in those help texts to work the WhatsThisClickedEvents are
handled in the main window class. This doesn't work for menus because
events from them aren't forwarded to the main window for some
reason so EventFilters are installed for the Control button menus.

Modifying the "Help" menu of KXmlGui is deprecated so no EventFilter
can be installed in the menubar. Therefore help texts without links
are provided for the menubar.

Test Plan

Check if the event handling might make any problems.
Check for any big mistakes in the help messages.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
felixernst created this revision.Apr 11 2019, 3:44 PM
Restricted Application added a subscriber: kfm-devel. · View Herald TranscriptApr 11 2019, 3:44 PM
felixernst requested review of this revision.Apr 11 2019, 3:44 PM

Thanks for fixing these typos.

src/dolphinmainwindow.cpp
1433

Typo: informations -> information

1438

Typo: informations -> information

felixernst updated this revision to Diff 56177.Apr 14 2019, 9:47 AM

fixed typos: informations -> information

felixernst marked 2 inline comments as done.Tue, May 14, 9:24 AM

Bump

felixernst edited the test plan for this revision. (Show Details)Tue, May 14, 9:36 AM

The patch does not apply, can you please rebase it?

elvisangelaccio requested changes to this revision.Sun, May 19, 10:09 AM
elvisangelaccio added inline comments.
src/dolphinmainwindow.cpp
82–83

Please keep the includes sorted by name.

1155

Please add const

1161

Please call it cutAction. (I know we use paste below for the paste action, but that's old code).

1167

Please call it copyAction.

1182

Please call it findAction.

1191

Please call it selectAllAction.

1427

Please add const

1912

Please add const

1928

Funny name :D

Please add const here as well

1950

Please add const

1962

Please add const

1976

Please add const

1984

Please add const

1991

Please add const

2003–2009

Coding style: please use

if (event->type() == QEvent::WhatsThisClicked) {

}
2014

Unnecessary semicolon.

2015–2021

Coding style (same as above).

This revision now requires changes to proceed.Sun, May 19, 10:09 AM
felixernst marked 17 inline comments as done.

Rebased to current master
Applied all the requested changes

(Having a bit of trouble with my dev environment right now
but I am moderately confident everything's alright.)