| broulik | |
| aacid |
| Frameworks |
Previous code (probably) worked only for l/100 km -> MPG but not the other way around. Fix this by using reciprocal conversion when necessary.
Output:
38.7 MPG -> 6.077 l/100 km; 16.455 km/l; 46.482 MPGI
16.455 km/l -> 6.077 l/100 km; 38.7 MPG
46.48 MPGI -> 6.077 l/100 km
Seems good to me.
BUG: 378967
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| src/fuel_efficiency.cpp | ||
|---|---|---|
| 48 | Indentation seems off here | |
| src/fuel_efficiency.cpp | ||
|---|---|---|
| 36 | I'm not sure I understand what isReciprocal means here. | |
| src/fuel_efficiency.cpp | ||
|---|---|---|
| 36 | l/100 km (amount of fuel needed to cross a given distance) is reciprocal to MPG (distance crossed with a given amount of fuel). KUnitConverter can only scale units by a given factor, not invert them which is what is needed to make this work. isReciprocal flag denotes that the conversion between the base unit (l/100 km) and the target unit shall be reciprocal. | |
| autotests/convertertest.cpp | ||
|---|---|---|
| 71 | Could you please also add a test where the initial value is in say MPG and then we have the conversion to liters/100km, mpgi and l/100 km? | |
| src/fuel_efficiency.cpp | ||
| 36 | I understand what you mean here, but i don't think that reciprocal is the word that describes this (are you a native speaker? if so maybe it's juts that my english is bad :D) Oh, it's actually called reciprocal number too, i think here we use the inverse naming for it https://en.wikipedia.org/wiki/Multiplicative_inverse Maybe naming it "m_isReciprocaltoDefaultUnit" would make it understand? i.e. makes it clear that that value is in relation to the default unit? | |
| src/fuel_efficiency.cpp | ||
|---|---|---|
| 36 | Direct translation from my native language would be "inverse" too, although somehow I prefer the word "reciprocal" as it feels less ambiguous. (People may perceive "inversion" in multiple ways but "reciprocity" has a pretty solid definition as far as math goes... IMHO :) ) Regardless, I changed the name and added an explanatory comment. | |