- User Since
- May 23 2017, 8:30 PM (129 w, 1 d)
Sat, Nov 2
Apr 14 2019
More obvious explanation of the meaning of m_isReciprocal
Added an inverse test with initial value in MPG
Apr 8 2019
Apr 6 2019
- Tweaked conversion factor to match those used by Google online converter
- Added test to convert l/100 km to other representations and back
Tabs vs spaces
Dec 21 2018
Did this just get lost in the pipe or should I consider the patch rejected?
Dec 9 2018
Oct 8 2018
Oct 3 2018
Changed the KIO error code from ERR_INTERNAL to more specific ERR_CANNOT_RMDIR.
Ah, sorry, apparently there is ERR_CANNOT_RMDIR and ERR_COULD_NOT_RMDIR which translate to the same value with the latter being deprecated. I'll update the patch to use ERR_CANNOT_RMDIR.
Well, this (https://api.kde.org/frameworks/kio/html/deprecated.html#_deprecated000015) marks KIO::ERR_COULD_NOT_RMDIR as deprecated. Is there an alternative I should use instead?
Oct 2 2018
@elvisangelaccio: OK, what do I have to do?
Oct 1 2018
May 11 2018
Thanks. Can you commit this for me as I don't have commit rights?
May 10 2018
Oct 30 2017
What is the status on upstreaming this? Is there anything else you need from me to finish this off?
Oct 23 2017
Oct 21 2017
- Check against a range of affected versions
- Small stylistic changes
Detect versions of libsmbclient libraries that are considered broken and apply the workaround only for those.
Oct 20 2017
Oh, of course, call it the "Friday evening attention level". Link to upstream report is not a part of the comment in the source.
Oct 4 2017
This looks reasonable to me. As far as I could test smb:/ and smb:// are now handled in the same fashion.
Jul 18 2017
The guideline suggests that a developer should not apply for a dev account if they do not intend to contribute over a longer period of time. As much as I'd like to help out as much as I can I'd prefer to not open a dev account to push these patches through.
Jul 16 2017
- Use more universal xi18n()
- Use a less technical description of the error
I know, but I prefer to reserve the struct keyword for C-only code.
Update to match the dependent patch
Check for the error code explicitly and report an error from reportWarning() method
Update to match changes in https://phabricator.kde.org/D6662
Instead of hardwiring ENOENT and ENOTDIR errnos provide a more generic function that will generate a warning if any from a list of errors occurs.
Jul 12 2017
As far as I can tell I have no issues with unwritable directories anymore. Note that this patch introduces a small behavior change, when browse_stat_path() encounters ENOENT or ENOTDIR, there is a warning displayed if browse_stat_path() is called from stat(). If it gets called from the listDir() loop, the error is ignored silently. Previous behavior displayed the warning in both cases. I suppose that treating ENOENT and ENOTDIR as an error from stat() and displaying a warning from listDir() would make more sense. I'd prefer to submit this as a separate patch if possible.
Change the logic of browse_stat_path() instead of working around its current behavior.
Jul 11 2017
Okay, I will try to rework this in a more sensible way.
Explain the need for the empty if in the loop.
Fix indentation issue.
Jul 10 2017
I'd rather commit under my primary phabricator email if you can view it.
Jul 9 2017
v2. The code now tries to leverage GLX_MESA_query_renderer when it is available and falls back to the old-fashioned probing otherwise. As for some of the suggestions by Martin:
Jul 8 2017
Fair enough, I'll give it another go. Would it make sense to follow this with a trivial NULL -> nullptr patch to keep the code in this file consistent?