madcatx (Michal Malý)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
May 23 2017, 8:30 PM (121 w, 5 d)
Availability
Available

Recent Activity

Apr 14 2019

madcatx added inline comments to D20284: Fix l/100 km to MPG conversion.
Apr 14 2019, 2:18 PM · Frameworks
madcatx updated the diff for D20284: Fix l/100 km to MPG conversion.

More obvious explanation of the meaning of m_isReciprocal

Apr 14 2019, 2:14 PM · Frameworks
madcatx updated the diff for D20284: Fix l/100 km to MPG conversion.

Added an inverse test with initial value in MPG

Apr 14 2019, 2:04 PM · Frameworks

Apr 8 2019

madcatx added inline comments to D20284: Fix l/100 km to MPG conversion.
Apr 8 2019, 2:56 AM · Frameworks

Apr 6 2019

madcatx updated the diff for D20284: Fix l/100 km to MPG conversion.
  1. Tweaked conversion factor to match those used by Google online converter
  2. Added test to convert l/100 km to other representations and back
Apr 6 2019, 3:38 PM · Frameworks
madcatx updated the diff for D20284: Fix l/100 km to MPG conversion.

Tabs vs spaces

Apr 6 2019, 7:03 AM · Frameworks
madcatx requested review of D20284: Fix l/100 km to MPG conversion.
Apr 6 2019, 6:46 AM · Frameworks

Dec 21 2018

madcatx added a comment to D17462: Close Yakuake window when it loses focus under Wayland.

Did this just get lost in the pipe or should I consider the patch rejected?

Dec 21 2018, 11:36 AM

Dec 9 2018

madcatx closed D17463: Use KWindowSystem to determine which display system is in use.
Dec 9 2018, 10:34 PM
madcatx committed R369:649ee7de4d0e: Use KWindowSystem to determine which display system is in use (authored by madcatx).
Use KWindowSystem to determine which display system is in use
Dec 9 2018, 10:34 PM
madcatx requested review of D17463: Use KWindowSystem to determine which display system is in use.
Dec 9 2018, 9:37 PM
madcatx requested review of D17462: Close Yakuake window when it loses focus under Wayland.
Dec 9 2018, 9:33 PM

Oct 8 2018

madcatx committed R320:a26de31a5dfb: Distinguish between file and directory delete request in debug output. (authored by madcatx).
Distinguish between file and directory delete request in debug output.
Oct 8 2018, 10:14 AM
madcatx closed D15873: Improve debugging output by displaying whether the SMBSlave::del() function attempts to delete a file or a directory..
Oct 8 2018, 10:14 AM · Frameworks, Dolphin
madcatx committed R320:75ee4dfb4042: Add a specific error string for ENOTEMPTY return code. (authored by madcatx).
Add a specific error string for ENOTEMPTY return code.
Oct 8 2018, 10:14 AM
madcatx closed D15871: Add a specific error string for ENOTEMPTY return code in SMB slave..
Oct 8 2018, 10:14 AM · Frameworks, Dolphin

Oct 3 2018

madcatx updated the diff for D15871: Add a specific error string for ENOTEMPTY return code in SMB slave..

Changed the KIO error code from ERR_INTERNAL to more specific ERR_CANNOT_RMDIR.

Oct 3 2018, 5:48 PM · Frameworks, Dolphin
madcatx added a comment to D15871: Add a specific error string for ENOTEMPTY return code in SMB slave..

Ah, sorry, apparently there is ERR_CANNOT_RMDIR and ERR_COULD_NOT_RMDIR which translate to the same value with the latter being deprecated. I'll update the patch to use ERR_CANNOT_RMDIR.

Oct 3 2018, 12:45 PM · Frameworks, Dolphin
madcatx added a comment to D15871: Add a specific error string for ENOTEMPTY return code in SMB slave..

Well, this (https://api.kde.org/frameworks/kio/html/deprecated.html#_deprecated000015) marks KIO::ERR_COULD_NOT_RMDIR as deprecated. Is there an alternative I should use instead?

Oct 3 2018, 12:40 PM · Frameworks, Dolphin

Oct 2 2018

madcatx added a comment to D15873: Improve debugging output by displaying whether the SMBSlave::del() function attempts to delete a file or a directory..

@elvisangelaccio: OK, what do I have to do?

Oct 2 2018, 10:57 AM · Frameworks, Dolphin

Oct 1 2018

madcatx requested review of D15873: Improve debugging output by displaying whether the SMBSlave::del() function attempts to delete a file or a directory..
Oct 1 2018, 9:24 AM · Frameworks, Dolphin
madcatx requested review of D15871: Add a specific error string for ENOTEMPTY return code in SMB slave..
Oct 1 2018, 9:20 AM · Frameworks, Dolphin
madcatx created T9778: Add a specific error string for ENOEMPTY return code in SMB slave.
Oct 1 2018, 9:16 AM · Frameworks

May 11 2018

madcatx added a comment to D12798: Constrain libsmbclient bug workaround to affected versions only.

Thanks. Can you commit this for me as I don't have commit rights?

May 11 2018, 9:29 AM

May 10 2018

madcatx requested review of D12798: Constrain libsmbclient bug workaround to affected versions only.
May 10 2018, 8:30 AM

Oct 30 2017

madcatx added a comment to D8387: Workaround incorrectly returned EEXIST instead of EPERM regression introduced by libsmbclient 4.7.

What is the status on upstreaming this? Is there anything else you need from me to finish this off?

Oct 30 2017, 9:45 AM

Oct 23 2017

madcatx added inline comments to D8387: Workaround incorrectly returned EEXIST instead of EPERM regression introduced by libsmbclient 4.7.
Oct 23 2017, 3:55 PM

Oct 21 2017

madcatx added a comment to D8387: Workaround incorrectly returned EEXIST instead of EPERM regression introduced by libsmbclient 4.7.

Do you have commit access? If not, I'll be happy to commit this once some more of the folks who have made comments have also signed off on a final version.

Oct 21 2017, 3:54 PM
madcatx updated the diff for D8387: Workaround incorrectly returned EEXIST instead of EPERM regression introduced by libsmbclient 4.7.
  • Check against a range of affected versions
  • Small stylistic changes
Oct 21 2017, 12:53 PM
madcatx added inline comments to D8387: Workaround incorrectly returned EEXIST instead of EPERM regression introduced by libsmbclient 4.7.
Oct 21 2017, 11:09 AM
madcatx added inline comments to D8387: Workaround incorrectly returned EEXIST instead of EPERM regression introduced by libsmbclient 4.7.
Oct 21 2017, 10:46 AM
madcatx updated the diff for D8387: Workaround incorrectly returned EEXIST instead of EPERM regression introduced by libsmbclient 4.7.

Tabs/spaces issue

Oct 21 2017, 10:42 AM
madcatx updated the diff for D8387: Workaround incorrectly returned EEXIST instead of EPERM regression introduced by libsmbclient 4.7.

Detect versions of libsmbclient libraries that are considered broken and apply the workaround only for those.

Oct 21 2017, 9:27 AM
madcatx added a comment to D8387: Workaround incorrectly returned EEXIST instead of EPERM regression introduced by libsmbclient 4.7.

So am I correct that this patch does the following:

  • If you go to a real password-protected samba server, without this patch you are totally screwed; with it, you are correctly offered a chance to enter your credentials
  • If you go to an invalid address that doesn't exist, without this patch you are told that; with it, you are erroneously offered a credentials window, making you think that the address is real

    If so, is there any other way to check whether the server address is valid besides getting back EEXIST?
Oct 21 2017, 7:05 AM

Oct 20 2017

madcatx updated the diff for D8387: Workaround incorrectly returned EEXIST instead of EPERM regression introduced by libsmbclient 4.7.

Oh, of course, call it the "Friday evening attention level". Link to upstream report is not a part of the comment in the source.

Oct 20 2017, 8:55 PM
madcatx updated the summary of D8387: Workaround incorrectly returned EEXIST instead of EPERM regression introduced by libsmbclient 4.7.
Oct 20 2017, 8:31 PM
madcatx retitled D8387: Workaround incorrectly returned EEXIST instead of EPERM regression introduced by libsmbclient 4.7 from [RFC] workaround a regression in libsmbclient 4.7 to Workaround incorrectly returned EEXIST instead of EPERM regression introduced by libsmbclient 4.7.
Oct 20 2017, 8:31 PM
madcatx created D8387: Workaround incorrectly returned EEXIST instead of EPERM regression introduced by libsmbclient 4.7.
Oct 20 2017, 8:00 PM

Oct 4 2017

madcatx added a comment to D8141: Fix smb:/ handling.

This looks reasonable to me. As far as I could test smb:/ and smb:// are now handled in the same fashion.

Oct 4 2017, 10:04 PM

Jul 18 2017

madcatx added a comment to D6732: Display the error message in warning dialog.

The guideline suggests that a developer should not apply for a dev account if they do not intend to contribute over a longer period of time. As much as I'd like to help out as much as I can I'd prefer to not open a dev account to push these patches through.

Jul 18 2017, 12:19 PM

Jul 16 2017

madcatx updated the diff for D6732: Display the error message in warning dialog.
  • Use more universal xi18n()
  • Use a less technical description of the error
Jul 16 2017, 6:38 PM
madcatx added a comment to D6731: Make error strings in a separate method.

I know, but I prefer to reserve the struct keyword for C-only code.

Jul 16 2017, 3:14 PM
madcatx created D6733: Do not set MIME type for the "." UDSEntry.
Jul 16 2017, 1:28 PM
madcatx added a dependency for D6732: Display the error message in warning dialog: D6731: Make error strings in a separate method.
Jul 16 2017, 1:24 PM
madcatx added a dependent revision for D6731: Make error strings in a separate method: D6732: Display the error message in warning dialog.
Jul 16 2017, 1:24 PM
madcatx created D6732: Display the error message in warning dialog.
Jul 16 2017, 1:24 PM
madcatx created D6731: Make error strings in a separate method.
Jul 16 2017, 1:22 PM
madcatx added a dependent revision for D6662: [PATCH 2/4] Add reportWarning() method: D6663: [PATCH 3/4] Do not list an UDSEntry for a file or directory that was not stat()'ed successfully.
Jul 16 2017, 12:16 PM
madcatx added a dependency for D6663: [PATCH 3/4] Do not list an UDSEntry for a file or directory that was not stat()'ed successfully: D6662: [PATCH 2/4] Add reportWarning() method.
Jul 16 2017, 12:16 PM
madcatx updated the diff for D6663: [PATCH 3/4] Do not list an UDSEntry for a file or directory that was not stat()'ed successfully.

Update to match the dependent patch

Jul 16 2017, 12:15 PM
madcatx updated the diff for D6662: [PATCH 2/4] Add reportWarning() method.

Check for the error code explicitly and report an error from reportWarning() method

Jul 16 2017, 12:14 PM
madcatx updated the diff for D6663: [PATCH 3/4] Do not list an UDSEntry for a file or directory that was not stat()'ed successfully.

Update to match changes in https://phabricator.kde.org/D6662

Jul 16 2017, 1:01 AM
madcatx updated the diff for D6662: [PATCH 2/4] Add reportWarning() method.

Instead of hardwiring ENOENT and ENOTDIR errnos provide a more generic function that will generate a warning if any from a list of errors occurs.

Jul 16 2017, 1:00 AM

Jul 12 2017

madcatx created D6664: [PATCH 4/4] Do not treat ENOENT and ENOTDIR differently in stat().
Jul 12 2017, 10:52 PM
madcatx created D6663: [PATCH 3/4] Do not list an UDSEntry for a file or directory that was not stat()'ed successfully.
Jul 12 2017, 10:48 PM
madcatx created D6662: [PATCH 2/4] Add reportWarning() method.
Jul 12 2017, 10:46 PM
madcatx created D6661: [PATCH 1/4] Remove extraneous "else if" branch.
Jul 12 2017, 10:43 PM
madcatx added a comment to D6617: Return appropriate error code from browse_stat_path() instead of trying to deal with the error internally..

As far as I can tell I have no issues with unwritable directories anymore. Note that this patch introduces a small behavior change, when browse_stat_path() encounters ENOENT or ENOTDIR, there is a warning displayed if browse_stat_path() is called from stat(). If it gets called from the listDir() loop, the error is ignored silently. Previous behavior displayed the warning in both cases. I suppose that treating ENOENT and ENOTDIR as an error from stat() and displaying a warning from listDir() would make more sense. I'd prefer to submit this as a separate patch if possible.

Jul 12 2017, 9:45 AM
madcatx updated the diff for D6617: Return appropriate error code from browse_stat_path() instead of trying to deal with the error internally..

Change the logic of browse_stat_path() instead of working around its current behavior.

Jul 12 2017, 8:29 AM

Jul 11 2017

madcatx added a comment to D6617: Return appropriate error code from browse_stat_path() instead of trying to deal with the error internally..

Okay, I will try to rework this in a more sensible way.

Jul 11 2017, 9:38 AM
madcatx added inline comments to D6616: Always create the "." UDSEntry.
Jul 11 2017, 9:35 AM
madcatx updated the diff for D6616: Always create the "." UDSEntry.

Explain the need for the empty if in the loop.

Jul 11 2017, 9:31 AM
madcatx added inline comments to D6616: Always create the "." UDSEntry.
Jul 11 2017, 9:27 AM
madcatx added a comment to D6617: Return appropriate error code from browse_stat_path() instead of trying to deal with the error internally..

What if we make browse_stat_path() return the error code if there is an error or 0 otherwise? This way the caller can choose whether to call finished() or reportError() + error(). The ignore_errors argument would also become useless.

Jul 11 2017, 9:04 AM
madcatx updated the diff for D6616: Always create the "." UDSEntry.

Fix indentation issue.

Jul 11 2017, 8:48 AM

Jul 10 2017

madcatx created D6617: Return appropriate error code from browse_stat_path() instead of trying to deal with the error internally..
Jul 10 2017, 9:50 PM
madcatx created D6616: Always create the "." UDSEntry.
Jul 10 2017, 9:37 PM
madcatx added a comment to D5947: Allow write access to Samba Shares' root.
Jul 10 2017, 5:30 PM
madcatx added a comment to D5947: Allow write access to Samba Shares' root.

I'd rather commit under my primary phabricator email if you can view it.

Jul 10 2017, 5:26 PM

Jul 9 2017

madcatx updated the diff for D6565: Query supported OpenGL core profile version on X11, GLX.

v2. The code now tries to leverage GLX_MESA_query_renderer when it is available and falls back to the old-fashioned probing otherwise. As for some of the suggestions by Martin:

Jul 9 2017, 10:56 AM · Plasma

Jul 8 2017

madcatx added a comment to D6565: Query supported OpenGL core profile version on X11, GLX.

Fair enough, I'll give it another go. Would it make sense to follow this with a trivial NULL -> nullptr patch to keep the code in this file consistent?

Jul 8 2017, 1:02 PM · Plasma
madcatx added a comment to D5947: Allow write access to Samba Shares' root.

Do you have commit access? Otherwise I can push this on your behalf so it doesn't get lost. Thanks.

Jul 8 2017, 11:18 AM
madcatx created D6567: Do not leak XVisualInfo (GLX path).
Jul 8 2017, 11:06 AM · Plasma
madcatx created D6566: Do not leak XVisualInfo (X11 EGL path).
Jul 8 2017, 11:05 AM · Plasma
madcatx created D6565: Query supported OpenGL core profile version on X11, GLX.
Jul 8 2017, 10:59 AM · Plasma

May 24 2017

madcatx added a reviewer for D5947: Allow write access to Samba Shares' root: elvisangelaccio.
May 24 2017, 6:17 AM

May 23 2017

madcatx created D5947: Allow write access to Samba Shares' root.
May 23 2017, 8:37 PM