$ dolphin some/file some/directory
$ dolphin some/file some/other/file some/file_second
I get a crash if I run dolphin /etc/fstab:
[12762 - default] unknown(): ASSERT: "dirs.size() > 0" in file ../src/dolphintabwidget.cpp, line 175
Thanks for noticing! I've updated the patch to fix the crash.
$ dolphin --select
(without file argument)
Opens up /home with $HOME directory selected. Is it the expected behavior?
I'm not an expert in dolphin but other than that it looks good to me. +1
No need to initialize with an empty list, it will be filled by default.
Just leave QList<QUrl> urlDirectories;
Use !urlDirectories.isEmpty(), it's a bit more direct.
toLocalFile() instead of path(), otherwise it breaks on Windows
Thanks for your comments! Revision updated.
Please make url a const reference. We should also prevent a possible detaching by using qAsConst(urls):
for (const QUrl &url : qAsConst(urls))