BUG: 377116
Details
Details
- Reviewers
elvisangelaccio - Group Reviewers
Dolphin
$ dolphin some/file some/directory
$ dolphin some/file some/other/file some/file_second
etc
Diff Detail
Diff Detail
- Repository
- R318 Dolphin
- Branch
- mkrutov/20190325/feat/files_as_arguments
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 10173 Build 10191: arc lint + arc unit
Comment Actions
I get a crash if I run dolphin /etc/fstab:
[12762 - default] unknown(): ASSERT: "dirs.size() > 0" in file ../src/dolphintabwidget.cpp, line 175
Comment Actions
Thanks for noticing! I've updated the patch to fix the crash.
Btw,
$ dolphin --select
(without file argument)
Opens up /home with $HOME directory selected. Is it the expected behavior?
src/main.cpp | ||
---|---|---|
146 | toLocalFile() instead of path(), otherwise it breaks on Windows |
src/main.cpp | ||
---|---|---|
144 | Please make url a const reference. We should also prevent a possible detaching by using qAsConst(urls): for (const QUrl &url : qAsConst(urls)) |