bluez-qt: remove warnings
Needs RevisionPublic

Authored by carneirogustavo on Mar 22 2019, 1:22 AM.

Details

Summary

Signed-off-by: Gustavo Carneiro <gcarneiroa@hotmail.com>

Diff Detail

Repository
R269 BluezQt
Branch
remove_compile_warnings
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9959
Build 9977: arc lint + arc unit
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 22 2019, 1:22 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
carneirogustavo requested review of this revision.Mar 22 2019, 1:22 AM
carneirogustavo retitled this revision from remove warnings to bluez-qt: remove warnings.Mar 22 2019, 1:22 AM
pino added a subscriber: pino.Mar 30 2019, 10:58 AM

Please describe what are the warnings: otherwise it is not clear what the problem was, and what was the solution implemented.
Remember: just because you see something on your system, it does not necessarly mean everybody else will, so each commit needs a proper explanation so everybody can understand why a change was made.

drosca accepted this revision.Apr 9 2019, 5:07 PM
This revision is now accepted and ready to land.Apr 9 2019, 5:07 PM
ngraham added a subscriber: ngraham.Apr 9 2019, 5:12 PM

@drosca I think you'll have to land this for @carneirogustavo.

drosca requested changes to this revision.Apr 9 2019, 5:35 PM

Actually ...

src/a2dp-codecs.c
59

Why this?

src/a2dp-codecs.h
135

Wouldn't ( (f) >> 4) be enough instead of adding the parenthesis below?

This revision now requires changes to proceed.Apr 9 2019, 5:35 PM