andreagenor (André Agenor)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 4 2018, 9:52 PM (36 w, 2 d)
Availability
Available

Recent Activity

May 8 2019

andreagenor committed R374:370ddfc27aae: Fix hsv effect when applied to image (authored by andreagenor).
Fix hsv effect when applied to image
May 8 2019, 12:01 PM
andreagenor closed D21046: Fix hsv effect when applied to image.
May 8 2019, 12:01 PM

May 6 2019

andreagenor added a comment to D21046: Fix hsv effect when applied to image.

can you put a screenshoot of the before / after ? I can't really read math.

May 6 2019, 2:45 PM
andreagenor added reviewers for D21046: Fix hsv effect when applied to image: tcanabrava, broulik.
May 6 2019, 2:34 PM
andreagenor requested review of D21046: Fix hsv effect when applied to image.
May 6 2019, 2:33 PM
andreagenor committed R374:2bcf99128c60: Speed up invert colors effect (authored by andreagenor).
Speed up invert colors effect
May 6 2019, 1:24 PM
andreagenor closed D20334: Speed up invert colors effect.
May 6 2019, 1:24 PM
andreagenor committed R374:777e84cb1e7f: Remove warning static member accessed through instance (authored by andreagenor).
Remove warning static member accessed through instance
May 6 2019, 1:23 PM
andreagenor closed D20335: Remove warning static member accessed through instance.
May 6 2019, 1:23 PM
andreagenor committed R374:c79d70a97241: Remove warning: do not use 'else' after 'return' (authored by andreagenor).
Remove warning: do not use 'else' after 'return'
May 6 2019, 1:22 PM
andreagenor closed D20398: Remove warning: do not use 'else' after 'return'.
May 6 2019, 1:22 PM

Apr 26 2019

andreagenor closed D20794: Simplify function return by removing the redundant empty object.
Apr 26 2019, 3:22 PM
andreagenor committed R374:74ccbd3a3765: Simplify function return by removing the redundant empty object (authored by andreagenor).
Simplify function return by removing the redundant empty object
Apr 26 2019, 3:22 PM

Apr 25 2019

andreagenor updated the diff for D20795: Remove warning - modernize: pass an argument by values and use std::move().
  • Add blank line to come back as original
Apr 25 2019, 2:05 PM
andreagenor updated the diff for D20795: Remove warning - modernize: pass an argument by values and use std::move().
  • Remove unnecessary headers
Apr 25 2019, 1:24 PM
andreagenor updated the diff for D20795: Remove warning - modernize: pass an argument by values and use std::move().
  • Correct the use of QString removing std::move
Apr 25 2019, 1:21 PM

Apr 24 2019

andreagenor added a reviewer for D20795: Remove warning - modernize: pass an argument by values and use std::move(): tcanabrava.
Apr 24 2019, 9:33 PM
andreagenor added a reviewer for D20794: Simplify function return by removing the redundant empty object: tcanabrava.
Apr 24 2019, 9:32 PM
andreagenor requested review of D20795: Remove warning - modernize: pass an argument by values and use std::move().
Apr 24 2019, 9:31 PM
andreagenor requested review of D20794: Simplify function return by removing the redundant empty object.
Apr 24 2019, 9:30 PM

Apr 9 2019

andreagenor added a comment to D20398: Remove warning: do not use 'else' after 'return'.
In D20398#446407, @pino wrote:

Which warnings do the two function trigger?
Also, adding { ... } breaks the code style.

Apr 9 2019, 2:19 PM
andreagenor updated the diff for D20398: Remove warning: do not use 'else' after 'return'.
  • Fix code style
Apr 9 2019, 2:13 PM
andreagenor added a comment to D20335: Remove warning static member accessed through instance.

This is the warning I get
https://clang.llvm.org/extra/clang-tidy/checks/readability-static-accessed-through-instance.html

Apr 9 2019, 2:11 PM
andreagenor added a comment to D20335: Remove warning static member accessed through instance.

true, but then the instance is there anyway. what we gain from this?

Apr 9 2019, 1:36 AM
andreagenor committed R374:cd6a79ef79db: remove the OpenMPI dependency (authored by andreagenor).
remove the OpenMPI dependency
Apr 9 2019, 1:34 AM
andreagenor closed D20322: remove the OpenMPI dependency.
Apr 9 2019, 1:34 AM
andreagenor closed D20336: Simplifying class constructor with constructor delegate.
Apr 9 2019, 1:32 AM
andreagenor committed R374:c8984f3eed88: Simplifying class constructor with constructor delegate (authored by andreagenor).
Simplifying class constructor with constructor delegate
Apr 9 2019, 1:32 AM
andreagenor added a reviewer for D20398: Remove warning: do not use 'else' after 'return': tcanabrava.
Apr 9 2019, 1:22 AM
andreagenor requested review of D20398: Remove warning: do not use 'else' after 'return'.
Apr 9 2019, 1:22 AM

Apr 7 2019

andreagenor updated the diff for D20334: Speed up invert colors effect.
  • Fix code style
Apr 7 2019, 8:11 AM
andreagenor added a comment to D20334: Speed up invert colors effect.
In D20334#445058, @pino wrote:

The API documentation of kpEffectInvert::applyEffect() says:

// Inverts the colours of each pixel in the given image.
// These functions differ from QImage::invertPixels() in the following ways:
//
// 1. for 8-bit images, it inverts the colours of the Colour Table
//    (this means that you would get visually similar results to inversion
//     at higher bit depths - rather than a "random-looking" inversion
//     depending on the contents of the Colour Table)
// 2. never inverts the Alpha Buffer

Did you check that the change does not invalidate these? (especially point 1)

Yes, I tested with all kind of images, from 1 to 32 bits. Everything works the same as before.
The changes affect only if all channels are selected, the conversion is faster than before in this case.

Apr 7 2019, 8:09 AM
andreagenor updated the summary of D20334: Speed up invert colors effect.
Apr 7 2019, 7:17 AM
andreagenor added a reviewer for D20336: Simplifying class constructor with constructor delegate: tcanabrava.
Apr 7 2019, 6:30 AM
andreagenor requested review of D20336: Simplifying class constructor with constructor delegate.
Apr 7 2019, 6:29 AM
andreagenor requested review of D20335: Remove warning static member accessed through instance.
Apr 7 2019, 6:09 AM
andreagenor added a reviewer for D20334: Speed up invert colors effect: tcanabrava.
Apr 7 2019, 5:54 AM
andreagenor requested review of D20334: Speed up invert colors effect.
Apr 7 2019, 5:53 AM

Apr 6 2019

andreagenor retitled D20322: remove the OpenMPI dependency from Remove OpenMP dependence to remove the OpenMPI dependency.
Apr 6 2019, 8:42 PM
andreagenor added a reviewer for D20322: remove the OpenMPI dependency: tcanabrava.
Apr 6 2019, 8:41 PM
andreagenor requested review of D20322: remove the OpenMPI dependency.
Apr 6 2019, 8:41 PM

Apr 2 2019

andreagenor added a comment to D20187: add .arcconfig file.

@patrickelectric @andreagenor will one of you commti this?

Apr 2 2019, 7:29 AM · KDE Games

Apr 1 2019

andreagenor accepted D20187: add .arcconfig file.
Apr 1 2019, 9:17 PM · KDE Games
andreagenor added a comment to D20187: add .arcconfig file.
Apr 1 2019, 9:11 PM · KDE Games
andreagenor added a project to D20187: add .arcconfig file: KDE Games.
Apr 1 2019, 9:08 PM · KDE Games
andreagenor added a comment to D20187: add .arcconfig file.

Why this file was added?
Please describe your intention with these patches.

Apr 1 2019, 9:00 PM · KDE Games

Mar 28 2019

andreagenor committed R374:f5d079c69e31: Correct math to blend color in the blur effect (authored by andreagenor).
Correct math to blend color in the blur effect
Mar 28 2019, 3:02 PM
andreagenor closed D20036: Correct math to blend color in the blur effect.
Mar 28 2019, 3:02 PM · KDE Applications

Mar 26 2019

andreagenor added a comment to D20036: Correct math to blend color in the blur effect.

Do you have an estimation of how fast is the code now with openmp ?

Mar 26 2019, 12:44 PM · KDE Applications
andreagenor updated the diff for D20036: Correct math to blend color in the blur effect.
  • Add OpenMP as a dependency
Mar 26 2019, 12:02 PM · KDE Applications

Mar 25 2019

andreagenor updated the diff for D20036: Correct math to blend color in the blur effect.
  • Added OpenMP to optimize loops and exchange std::pow to multiply
Mar 25 2019, 9:43 PM · KDE Applications
andreagenor updated the summary of D20036: Correct math to blend color in the blur effect.
Mar 25 2019, 2:21 AM · KDE Applications
andreagenor added a project to D20036: Correct math to blend color in the blur effect: KDE Applications.
Mar 25 2019, 2:16 AM · KDE Applications
andreagenor requested review of D20036: Correct math to blend color in the blur effect.
Mar 25 2019, 2:02 AM · KDE Applications

Mar 18 2019

andreagenor abandoned D19813: Fix freeze when resize with transparent option.
Mar 18 2019, 7:38 PM · KDE Applications

Mar 17 2019

andreagenor added a comment to D19808: elisa: code edent.

I know it's just a test and I think irrelevant to land in the master.

Mar 17 2019, 7:13 PM
andreagenor added a comment to D19813: Fix freeze when resize with transparent option.

I don't think is necessary to revert. I'm working to modernize and clean up the code and this commit solves the problem at this time. In the future, I will create a better solution and maybe complete remove these logs.
I think these logs was made just to debug in some development phase but is not required anymore.

Mar 17 2019, 7:39 AM · KDE Applications
andreagenor added a comment to D19813: Fix freeze when resize with transparent option.
In D19813#432369, @pino wrote:

The commit message is too generic, and it does not actually say what was the problem.
Also, the patch is completely unrelated to what the commit message (generically) says.

Mar 17 2019, 6:33 AM · KDE Applications
andreagenor added a project to D19813: Fix freeze when resize with transparent option: KDE Applications.
Mar 17 2019, 3:26 AM · KDE Applications
andreagenor added a reviewer for D19813: Fix freeze when resize with transparent option: tcanabrava.
Mar 17 2019, 3:25 AM · KDE Applications
andreagenor requested review of D19813: Fix freeze when resize with transparent option.
Mar 17 2019, 3:24 AM · KDE Applications

Mar 14 2019

andreagenor committed R374:decc2d76df6b: Modernizes and remove Clang-Tyde warnings (authored by andreagenor).
Modernizes and remove Clang-Tyde warnings
Mar 14 2019, 12:27 PM
andreagenor closed D19164: Modernizes and remove Clang-Tyde warnings.
Mar 14 2019, 11:01 AM

Mar 3 2019

andreagenor updated the diff for D19164: Modernizes and remove Clang-Tyde warnings.

remove conflicts

Mar 3 2019, 10:09 PM

Feb 26 2019

andreagenor added a project to D18742: Remove unused code: KDE Applications.
Feb 26 2019, 10:38 AM · KDE Applications

Feb 19 2019

andreagenor added a reviewer for D19164: Modernizes and remove Clang-Tyde warnings: tcanabrava.
Feb 19 2019, 5:37 PM
andreagenor requested review of D19164: Modernizes and remove Clang-Tyde warnings.
Feb 19 2019, 5:37 PM

Feb 11 2019

andreagenor added reviewers for D18927: Changed to use correct object signal: tcanabrava, broulik.
Feb 11 2019, 3:48 PM
andreagenor requested review of D18927: Changed to use correct object signal.
Feb 11 2019, 3:46 PM
andreagenor added a comment to D18741: Convert old style to Qt5 style connection.

This breaks the font tool, can no longer change font style or font size

Feb 11 2019, 2:36 AM

Feb 9 2019

andreagenor added a reviewer for D18876: Replace some math macro definitions: tcanabrava.
Feb 9 2019, 2:09 PM
andreagenor requested review of D18876: Replace some math macro definitions.
Feb 9 2019, 2:09 PM
andreagenor added a reviewer for D18872: Standardizing includes across header files: tcanabrava.
Feb 9 2019, 12:49 PM
andreagenor requested review of D18872: Standardizing includes across header files.
Feb 9 2019, 12:49 PM

Feb 5 2019

andreagenor updated the diff for D18742: Remove unused code.
  • Remove code conflicts
Feb 5 2019, 2:49 PM · KDE Applications
andreagenor added a reviewer for D18743: Add zero before dot to float point values: tcanabrava.
Feb 5 2019, 4:09 AM
andreagenor requested review of D18743: Add zero before dot to float point values.
Feb 5 2019, 4:08 AM
andreagenor added a reviewer for D18742: Remove unused code: tcanabrava.
Feb 5 2019, 3:57 AM · KDE Applications
andreagenor requested review of D18742: Remove unused code.
Feb 5 2019, 3:57 AM · KDE Applications
andreagenor added a reviewer for D18741: Convert old style to Qt5 style connection: tcanabrava.
Feb 5 2019, 3:36 AM
andreagenor requested review of D18741: Convert old style to Qt5 style connection.
Feb 5 2019, 3:35 AM

Feb 3 2019

andreagenor updated the diff for D18602: Remove break statement after return call.
  • Remove the default case and leave transparent one
Feb 3 2019, 1:57 PM

Jan 29 2019

andreagenor added a reviewer for D18602: Remove break statement after return call: tcanabrava.
Jan 29 2019, 6:21 PM
andreagenor requested review of D18602: Remove break statement after return call.
Jan 29 2019, 6:19 PM
andreagenor added a reviewer for D18595: Standardizing includes across all project files: tcanabrava.
Jan 29 2019, 2:09 PM
andreagenor requested review of D18595: Standardizing includes across all project files.
Jan 29 2019, 2:07 PM

Jan 18 2019

andreagenor updated the diff for D18316: Remove misuse of the comma operator.
  • Adjust the indentation to tabular style
Jan 18 2019, 9:41 AM
andreagenor added a comment to D18316: Remove misuse of the comma operator.

Yes, it works fine. Just to remove warnings.

Jan 18 2019, 2:01 AM

Jan 17 2019

andreagenor added a reviewer for D18337: Remove warning: zero as null pointer constant: tcanabrava.
Jan 17 2019, 9:21 PM
andreagenor requested review of D18337: Remove warning: zero as null pointer constant.
Jan 17 2019, 9:20 PM
andreagenor updated the diff for D18316: Remove misuse of the comma operator.
  • Correct the code indentation
Jan 17 2019, 4:31 PM
andreagenor added a reviewer for D18316: Remove misuse of the comma operator: tcanabrava.
Jan 17 2019, 12:45 PM
andreagenor requested review of D18316: Remove misuse of the comma operator.
Jan 17 2019, 12:45 PM
andreagenor added a reviewer for D18311: Convert old-style cast to C++ style: tcanabrava.
Jan 17 2019, 10:17 AM
andreagenor requested review of D18311: Convert old-style cast to C++ style.
Jan 17 2019, 10:15 AM