With the current settings text in color scheme previews is blurry. This patch aims to fix that and as a side-effect also creates more room in the grid layout now fitting 4 rows instead of 3 in minimum window size.
Details
Details
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Branch
- fix-blurry-previews (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 9089 Build 9107: arc lint + arc unit
Comment Actions
If this is too small the next number that doesn't result in blurry previews is multiplying with 16:
Comment Actions
I don't understand
Kirigami.gridUnit is a whole number
13 is a a whole number
Why does Math.round fix anything?
Comment Actions
Looks like KCM GridView should round the cell sizes to avoid non-integer pixel alignment
Comment Actions
Actually now that I take a closer look all of our previews are blurry. It's because there's text in the colors KCM that it becomes obvious.
Compare the desktop theme KCM preview in its original state:
And then with cell width set the same way as in this diff:
Clearly this needs to be handled in the GridView files. So far I haven't been successfully in fixing it there so if anyone else has an idea let's fix it.
Comment Actions
@filipf It's time for to learn the magic of gammaray !
gammaray kcmshell5 colors
and go to the quick scenes tabs. It might tell you something useful.
Comment Actions
Gammaray in Manjaro crashes any time Quick Scenes is opened for whichever KCM, KDE Neon Dev Unstable's Gammaray doesn't even have Quick Scenes :/
As for possible solutions, I've tried adding Math.round just about anywhere possible in GridView and GridViewKCM but to no avail. Also tried pixelAligned but that didn't seem to work either.
It would probably be best to continue search for the cause and solution on a bug report. I've found this one: https://bugs.kde.org/show_bug.cgi?id=393995