Differential D19339

Add option to change drive label to places panel context menu
Changes PlannedPublic
Actions

Authored by chinmoyr on Feb 26 2019, 1:27 PM.

Details

Reviewers
None
Group Reviewers
Dolphin
Frameworks
Summary

Uses org.freedesktop.UDisks2 dbus service for changing drive label.

Diff Detail

Repository
R318 Dolphin
Branch
change-label
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8871
Build 8889: arc lint + arc unit
chinmoyr created this revision.Feb 26 2019, 1:27 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptFeb 26 2019, 1:27 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
chinmoyr requested review of this revision.Feb 26 2019, 1:27 PM
bruns added a subscriber: bruns.Feb 26 2019, 1:58 PM

This definitely should not be implemented in dolphin ...

ngraham added a subscriber: ngraham.Feb 26 2019, 2:01 PM

Yeah, it would be nice to get this into KIO's own Places Panel model instead so it can be done from any KDE app with a Places Panel. +1 for the feature though!

Also screenshots are appreciated. :) https://community.kde.org/Infrastructure/Phabricator#Include_some_screenshots

broulik added a subscriber: broulik.Feb 26 2019, 2:03 PM

Also, this should probably go into Solid StorageVolume with proper backend abstraction

chinmoyr planned changes to this revision.Feb 26 2019, 2:05 PM

Revision Contents
Changeset List

Diff 52611

View Options

src/panels/places/placesitemmodel.h

Loading...
View Options

src/panels/places/placesitemmodel.cpp

Loading...
View Options

src/panels/places/placespanel.cpp

Loading...