Differential D19121

Allow Gwenview to be able to open .kra (Krita) files
ClosedPublic
Actions

Authored by ngraham on Feb 18 2019, 3:59 PM.

Details

Reviewers
sitter
cfeck
Group Reviewers
Gwenview
Commits
R260:5ae28dadba06: Allow Gwenview to be able to open .kra (Krita) files
Summary

Add support for opening Krita files.

FEATURE: 337272
FIXED-IN: 19.04.0

Depends on D19120

Test Plan
  • Apply the patch and then this one for Krita: D19120
  • Rebuild and install both apps
  • Run sudo update-desktop-database
  • Right-click on a .kra file in Dolphin. Krita shows up as the top app to open it, with Gwenview showing up in the "Open With" menu

Diff Detail

Repository
R260 Gwenview
Branch
add-krita-file-support (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8480
Build 8498: arc lint + arc unit
ngraham created this revision.Feb 18 2019, 3:59 PM
Restricted Application added a project: Gwenview. · View Herald TranscriptFeb 18 2019, 3:59 PM
ngraham requested review of this revision.Feb 18 2019, 3:59 PM
ngraham edited the summary of this revision. (Show Details)Feb 18 2019, 4:20 PM
ngraham updated this revision to Diff 52010.Feb 18 2019, 8:50 PM

Rebase on current master

sitter accepted this revision.Feb 19 2019, 2:51 PM

FTR: kra support comes from kimageformats plugins to qimage. so do other already listed mimetypes though - it's fine.

It may make sense to make cmake indicate that kimageformats is a (recommended) runtime dep though. example: https://phabricator.kde.org/R135:f1191def10a04ea3d0e591ca9af9117ad64678ee

This revision is now accepted and ready to land.Feb 19 2019, 2:51 PM
ngraham added a comment.Feb 19 2019, 3:33 PM

Sweet, will add the dep in another patch.

Closed by commit R260:5ae28dadba06: Allow Gwenview to be able to open .kra (Krita) files (authored by ngraham). · Explain WhyFeb 19 2019, 3:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 51972

View Options

app/org.kde.gwenview.desktop.cmake

Loading...
View Options

part/gvpart.desktop

Loading...