Differential D19121

Allow Gwenview to be able to open .kra (Krita) files
ClosedPublic
Actions

Authored by ngraham on Feb 18 2019, 3:59 PM.

Details

Reviewers

sitter
cfeck

Group Reviewers

Gwenview

Commits

R260:5ae28dadba06: Allow Gwenview to be able to open .kra (Krita) files

Summary

Add support for opening Krita files.

FEATURE: 337272
FIXED-IN: 19.04.0

Depends on D19120

Test Plan

Apply the patch and then this one for Krita: D19120
Rebuild and install both apps
Run sudo update-desktop-database
Right-click on a .kra file in Dolphin. Krita shows up as the top app to open it, with Gwenview showing up in the "Open With" menu

Diff Detail

Repository

R260 Gwenview

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ngraham created this revision.Feb 18 2019, 3:59 PM

Restricted Application added a project: Gwenview. · View Herald TranscriptFeb 18 2019, 3:59 PM

ngraham requested review of this revision.Feb 18 2019, 3:59 PM

Harbormaster completed remote builds in B8480: Diff 51972.Feb 18 2019, 3:59 PM

ngraham mentioned this in D19120: Be the top handler for .kra files by default.Feb 18 2019, 4:00 PM

ngraham edited the test plan for this revision. (Show Details)

ngraham mentioned this in R37:5997c73c7fa7: Be the top handler for .kra files by default.Feb 18 2019, 4:09 PM

rempt mentioned this in R37:55a1810389b4: Be the top handler for .kra files by default.Feb 18 2019, 4:15 PM

ngraham edited the summary of this revision. (Show Details)Feb 18 2019, 4:20 PM

Rebase on current master

FTR: kra support comes from kimageformats plugins to qimage. so do other already listed mimetypes though - it's fine.

It may make sense to make cmake indicate that kimageformats is a (recommended) runtime dep though. example: https://phabricator.kde.org/R135:f1191def10a04ea3d0e591ca9af9117ad64678ee

This revision is now accepted and ready to land.Feb 19 2019, 2:51 PM

Sweet, will add the dep in another patch.

Closed by commit R260:5ae28dadba06: Allow Gwenview to be able to open .kra (Krita) files (authored by ngraham). · Explain WhyFeb 19 2019, 3:40 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	51972	7afa340		Feb 18 2019, 3:59 PM	★	★
Diff 2	52010			Feb 18 2019, 8:49 PM	★	★
Diff 3	52080	b99e6a5	R260:5ae28dadba069a56b845c66c6a57f65c3883ede3	Feb 19 2019, 3:39 PM	★	★

	Status	Author	Revision
	Closed	ngraham	D19121 Allow Gwenview to be able to open .kra (Krita) files
	Closed	ngraham	D19120 Be the top handler for .kra files by default

Diff 52080

View Options

Allow Gwenview to be able to open .kra (Krita) filesClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 52080

CMakeLists.txt

Allow Gwenview to be able to open .kra (Krita) files
ClosedPublic
Actions

Revision Contents
Changeset List