The extraction of the aspect ratio was broken
for multiple reasons. Using the function
provided by ffmpeg fixes this.
Details
Details
- Reviewers
bruns ngraham - Commits
- R286:1082b1e009bc: Fix extraction of aspect ratio property
Diff Detail
Diff Detail
- Repository
- R286 KFileMetaData
- Branch
- ffmpeg_aspectratio
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 8562 Build 8580: arc lint + arc unit
| autotests/ffmpegextractortest.cpp | ||
|---|---|---|
| 53 ↗ | (On Diff #51918) | 16.0/9 |
| src/formatstrings.cpp | ||
|---|---|---|
| 157 | Proper i18n | |
| src/formatstrings.cpp | ||
|---|---|---|
| 157 | That was actually done deliberately to get this in for Kf 5.56 since there is string freeze. But if concatenation is a no go, this has to wait | |
| src/formatstrings.cpp | ||
|---|---|---|
| 157 | Thats obviously just avoiding the rules. You can ask for an exception anyway. | |
| src/formatstrings.cpp | ||
|---|---|---|
| 157 | The intention was to land the fix as soon as possible while complying to the rules, and fixing the i18n in the following frameworks release. | |