Increase precision of frame rate property
ClosedPublic

Authored by astippich on Sun, Feb 17, 7:31 PM.

Details

Summary

Some video files have frame rates
of 23.976 or similar, requiring the representation
as double. The data will be displayed
with two digit precision, as done by
kdenlive for example.

Diff Detail

Repository
R286 KFileMetaData
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich created this revision.Sun, Feb 17, 7:31 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptSun, Feb 17, 7:31 PM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
astippich requested review of this revision.Sun, Feb 17, 7:31 PM
bruns added inline comments.Sun, Feb 17, 8:28 PM
autotests/ffmpegextractortest.cpp
50

You can probably use (24.0/1001) for the exact value.

astippich updated this revision to Diff 52103.Tue, Feb 19, 7:24 PM
  • rebase on master
  • use exact value in test
bruns requested changes to this revision.Tue, Feb 19, 7:35 PM
bruns added inline comments.
This revision now requires changes to proceed.Tue, Feb 19, 7:35 PM
astippich updated this revision to Diff 52109.Tue, Feb 19, 8:20 PM
  • do not use QString::number
astippich marked 2 inline comments as done.Tue, Feb 19, 8:21 PM
bruns accepted this revision.Tue, Feb 19, 11:08 PM
This revision is now accepted and ready to land.Tue, Feb 19, 11:08 PM
This revision was automatically updated to reflect the committed changes.