Fix extraction of aspect ratio property
ClosedPublic

Authored by astippich on Feb 17 2019, 7:37 PM.

Details

Summary

The extraction of the aspect ratio was broken
for multiple reasons. Using the function
provided by ffmpeg fixes this.

Diff Detail

Repository
R286 KFileMetaData
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich created this revision.Feb 17 2019, 7:37 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptFeb 17 2019, 7:37 PM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
astippich requested review of this revision.Feb 17 2019, 7:37 PM
bruns added inline comments.Feb 17 2019, 8:31 PM
autotests/ffmpegextractortest.cpp
45

16.0/9

astippich updated this revision to Diff 52104.Tue, Feb 19, 7:28 PM
  • rebase
  • use exact value for test
bruns requested changes to this revision.Tue, Feb 19, 7:37 PM
bruns added inline comments.
src/formatstrings.cpp
157

Proper i18n

This revision now requires changes to proceed.Tue, Feb 19, 7:37 PM
astippich updated this revision to Diff 52114.Tue, Feb 19, 8:27 PM
  • do not use QString::number
astippich marked an inline comment as done.Tue, Feb 19, 8:32 PM
astippich added inline comments.
src/formatstrings.cpp
157

That was actually done deliberately to get this in for Kf 5.56 since there is string freeze. But if concatenation is a no go, this has to wait

bruns accepted this revision.Tue, Feb 19, 11:08 PM
bruns added inline comments.
src/formatstrings.cpp
157

Thats obviously just avoiding the rules. You can ask for an exception anyway.

This revision is now accepted and ready to land.Tue, Feb 19, 11:08 PM
astippich marked an inline comment as done.Wed, Feb 20, 6:56 AM
astippich added inline comments.
src/formatstrings.cpp
157

The intention was to land the fix as soon as possible while complying to the rules, and fixing the i18n in the following frameworks release.

This revision was automatically updated to reflect the committed changes.