Display the tooltip with the full label for truncated items
BUG: 390804
ngraham | |
hein | |
broulik |
Plasma |
Display the tooltip with the full label for truncated items
BUG: 390804
Lint Skipped |
Unit Tests Skipped |
Very nice! This fixes the bug and the code change looks sane. @hein are you good with this?
What's all the unrelated code changes about mouse handling trying to achieve?
Have you tested this with a few common screen resolutions / aspect ratios? The original grid was designed to try and avoid getting into awkward row configurations on common ones.
Can you ask more specifically? What lines do you think they are not necessary?
Because I add a theme.mSize(theme.defaultFont).height the cellSize becomes bigger so I try to remove some other spaces to avoid size changing as much as possible.
I've only tested it on the 1366x768 16:9 screen. What resolutions / aspect ratios do you think there will be some problem?
applets/kicker/package/contents/ui/ItemGridDelegate.qml | ||
---|---|---|
118 | What do the hover changes do in this patch? :) |
applets/kicker/package/contents/ui/ItemGridDelegate.qml | ||
---|---|---|
118 | It helps to display the tooltip. |
I'm sorry, but I can't accept this patch as-is - the hoverArea-related changes are just wrong, it's not OK to couple a delegate to the view by making it set tons of property on an item i its parent. I'll need to set some time aside to analyze what you're trying to achieve there and propose an alternative.
I'm concerned that having title labels on everything could be overdoing it a bit? It makes the context menu very large and have a lot of dead space, and adds to the noise. Isn't that rather a detriment to utility on repeated use? It's sometimes important to remember new users don't stay new users for very long, and first-time use isn't the only experience to optimize for.
Also, I do get a lot of user reports every time the window title bar menu and the task context menu diverge. Personally I've never felt that they need to match because tasks aren't windpw title bars, but it's worth keeping in mind.
I just want 2 things:
That's all, no matter how you do it.
Basically, I don't want to add any new feature, just want to make the existed stuff usable. (Currently it's not usable while it's existing)
Thank you!
Which is fine, I don't disagree with the goal :). Just that the particular implementation (the hover changes in the delegate) aren't a good way to do it.
As for the comment after, sorry, I accidentally posted it in the wrong ticket, you can ignore that.
Does this patch only concern itself with the icons and labels below them or also the categories on the right? If so, it feels like the category labels on the right are huge in comparison to the icon labels. Maybe those also need some touch up?
Now this patch only fixes the tooltip bug.
The other issues should be in another one.