Use propertymap to store properties in Baloo::Result
ClosedPublic

Authored by bruns on Feb 17 2019, 1:10 AM.

Details

Summary

Storing properties directly in a PropertyMap is more efficient (no
temporary conversion of property number to string, lookup with integer
key), and it also guarantees to have the same data as the extractor used
by BalooWigets, as long as (de)serialization to the Json format stored in
the DB is lossless.

Depends on D19087

Test Plan

ctest

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Feb 17 2019, 1:10 AM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptFeb 17 2019, 1:10 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Feb 17 2019, 1:10 AM
astippich accepted this revision.Sep 7 2019, 12:39 PM
astippich added inline comments.
src/lib/file.cpp
121

We are already using Baloo namespace here.

This revision is now accepted and ready to land.Sep 7 2019, 12:39 PM
ngraham accepted this revision.Sep 8 2019, 10:25 AM

ping @bruns
are you going to land this series?

This revision was automatically updated to reflect the committed changes.