Add a test and document PropertyMap/VariantMap conversion
AbandonedPublic

Authored by astippich on Sun, Feb 17, 7:15 PM.

Details

Reviewers
bruns
ngraham
Summary

Add a roundtrip test and document the
conversion function.

Diff Detail

Repository
R286 KFileMetaData
Branch
map_conversion
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8441
Build 8459: arc lint + arc unit
astippich created this revision.Sun, Feb 17, 7:15 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptSun, Feb 17, 7:15 PM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
astippich requested review of this revision.Sun, Feb 17, 7:15 PM
bruns added a comment.Thu, Feb 21, 7:22 PM

These two conversion functions should just be deprecated, as they are not expecially useful.

toPropertyMap is only used (an no longer will be after D19088) inside baloo as a temporary for the Json conversion, and toVariantMap is completely unused.

src/properties.h
367

This is wrong. How it is stored is internal to the map implementation, but
in general keys and values are stored independently.

The typedef itself documents everything there is to know.