add simple test for string merging
Needs ReviewPublic

Authored by astippich on Sun, Dec 2, 11:28 AM.

Details

Reviewers
bruns
Group Reviewers
Baloo
Summary

adds a simple test for the result class
that tests how multiple entries from the extractors
with the same property are merged into a list.

Test Plan

test passes

Diff Detail

Repository
R293 Baloo
Branch
test_result
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5906
Build 5924: arc lint + arc unit
astippich created this revision.Sun, Dec 2, 11:28 AM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptSun, Dec 2, 11:28 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
astippich requested review of this revision.Sun, Dec 2, 11:28 AM

Didn't found what I wanted to find, but since the code is there we can add it.

bruns added inline comments.Sun, Dec 2, 1:56 PM
autotests/unit/file/resulttest.cpp
3

^_^

40

Spaces and linebreaks ...

41

No need to reset the default constructed Baloo::Document with a default constructed one.

astippich updated this revision to Diff 46710.Sun, Dec 2, 2:48 PM
astippich marked 2 inline comments as done.
  • small fixes
astippich added inline comments.Sun, Dec 2, 2:49 PM
autotests/unit/file/resulttest.cpp
41

Actually it is. The TermGenerators are otherwise only initialized with nullptr, and consequently will crash. That is something that should be fixed (separately).

bruns added inline comments.Sun, Dec 2, 4:04 PM
autotests/unit/file/resulttest.cpp
41
astippich updated this revision to Diff 47329.Tue, Dec 11, 8:31 AM
  • updates for master

I was recently wondering if this is actually desired behavior. Right now it is definitely required since KFileMetaData wrongly outputs QStrings instead of a QStringList, but when this is fixed, this behavior should be removed imho. Otherwise, querying metadata via KFileMetaData and via Baloo differs in output, which it shouldn't.