KRun: add runApplication method.
ClosedPublic

Authored by dfaure on Jun 15 2016, 7:35 PM.

Details

Summary

The main purpose compared to runService is to use QProcess directly rather
than KLauncher. In e.g. Plasma launchers, using KLauncher can block the
GUI for a long time, for no purpose since we're not actually going to make DBus
calls to it. In the long run, we could move towards DBus activation for such cases,
and runApplication otherwise.

While making a new method, I also took the opportunity to turn the bool tempFiles
to a QFlags.

The purpose of this is to be able to clean up the plasma fix https://phabricator.kde.org/D1898
one day.

Test Plan

Added a testcase to the unittest.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
dfaure updated this revision to Diff 4528.Jun 15 2016, 7:35 PM
dfaure retitled this revision from to KRun: add runApplication method..
dfaure updated this object.
dfaure edited the test plan for this revision. (Show Details)
dfaure added reviewers: Plasma, hein, broulik.
dfaure removed a reviewer: Plasma.Jun 15 2016, 7:36 PM
dfaure added a reviewer: davidedmundson.
dfaure added subscribers: Frameworks, Plasma.
davidedmundson accepted this revision.Jun 15 2016, 9:00 PM
davidedmundson edited edge metadata.
This revision is now accepted and ready to land.Jun 15 2016, 9:00 PM
svuorela accepted this revision.Jun 16 2016, 7:35 PM
svuorela added a reviewer: svuorela.
dfaure closed this revision.Jun 16 2016, 8:42 PM