"new KRun" is only meant to run absolute file paths and so breaks when we get a
service with relative entryPath() like when finding a KCModule.
The tempFile argument causes this call to be asynchronous as to not block the UI
Details
Details
The tempFile hack has David Faure's blessing as new KRun is only meant for when opening files and the like. KRun::runService normally blocks but doesn't when we do the tempFiles thing. This fixes opening eg KCMs (search for eg "Splash" and add it to favorites).
- Opening apps in favorites still works
- Opening apps in recent docs still works
- OPening docs in recent docs still works
- Opening apps in apps still works
- Opening KCMs in favorites now works
- Opening KCMs in recent docs now works
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Yes, but please add a comment about porting to KRun::runApplication once https://phabricator.kde.org/D1902 is merged in and you can rely on KF 5.24 :-)