Add trim margins and trim to selection icons
ClosedPublic
Actions

Authored by trickyricky26 on Jan 26 2019, 4:51 PM.

Details

Reviewers

ngraham
ndavis

Group Reviewers

VDG

Commits

R266:8b412d0fc4be: Add trim margins and trim to selection icons

Summary

BUG: 401489

FIXED-IN: 5.55

Add trim-margins and trim-to-selection action icons.

Test Plan

With Breeze-dark theme:

Diff Detail

Repository

R266 Breeze Icons

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

trickyricky26 created this revision.Jan 26 2019, 4:51 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptJan 26 2019, 4:51 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

trickyricky26 requested review of this revision.Jan 26 2019, 4:51 PM

Harbormaster completed remote builds in B7559: Diff 50334.Jan 26 2019, 4:51 PM

I'm not quite sure about the naming and the 32px trim-to-selection design as it shows the entire page as opposed to the other sizes.

I love these icons! Just what I had in mind. I think they're great how they are.

This revision is now accepted and ready to land.Jan 26 2019, 5:01 PM

Going to make one more tiny change

I really like this and I'm going to accept it as is, but what do other VDG people think about the difference between the 32px and smaller versions of trim to margins? I know it's hard to fit in details when you're working with 16px or 22px icons.

BTW, how did you change the colors of the labels for montage?

In D18552#400495, @ndavis wrote:

BTW, how did you change the colors of the labels for montage?

I added -fill '#ffffff' to the command.

abetts added a subscriber: abetts.Jan 26 2019, 5:06 PM

abetts removed a subscriber: abetts.

Would you guys consider documenting your process for producing these nice composite images somewhere? Maybe on the HIG icons page (https://hig.kde.org/style/icon.html), or on the Phabricator documentation page (https://community.kde.org/Infrastructure/Phabricator)

I think the differences between those icon sizes is okay. If it's considered a problem, maybe we could make the 32px version match the smaller ones and omit the bottom line. I imagine adding a bottom line to the smaller sizes wasn't visually acceptable?

Enlarge faded lines in trim-to-selection icons

This revision is now accepted and ready to land.Jan 26 2019, 5:17 PM

Harbormaster completed remote builds in B7561: Diff 50336.Jan 26 2019, 5:17 PM

In D18552#400508, @ngraham wrote:

I think the differences between those icon sizes is okay. If it's considered a problem, maybe we could make the 32px version match the smaller ones and omit the bottom line. I imagine adding a bottom line to the smaller sizes wasn't visually acceptable?

Yes, it is not possible at smaller sizes due to space constraints.

All right, let's go with this!

Closed by commit R266:8b412d0fc4be: Add trim margins and trim to selection icons (authored by trickyricky26, committed by ngraham). · Explain WhyJan 26 2019, 5:21 PM

This revision was automatically updated to reflect the committed changes.

ngraham mentioned this in D15193: Add icons for the Trim Margins tools.Jan 26 2019, 5:37 PM

ngraham mentioned this in R223:259961f6d18f: Add icons for the Trim Margins tools.Jan 26 2019, 8:57 PM

Revision Contents
Changeset List

		Path
A	M	icons-dark/actions/16/trim-margins.svg (1 line)
A	M	icons-dark/actions/16/trim-to-selection.svg (1 line)
A	M	icons-dark/actions/22/trim-margins.svg (1 line)
A	M	icons-dark/actions/22/trim-to-selection.svg (1 line)
A	M	icons-dark/actions/24/trim-margins.svg (1 line)
A	M	icons-dark/actions/24/trim-to-selection.svg (1 line)
A	M	icons-dark/actions/32/trim-margins.svg (1 line)
A	M	icons-dark/actions/32/trim-to-selection.svg (1 line)
A	M	icons/actions/16/trim-margins.svg (1 line)
A	M	icons/actions/16/trim-to-selection.svg (1 line)
A	M	icons/actions/22/trim-margins.svg (1 line)
A	M	icons/actions/22/trim-to-selection.svg (1 line)
A	M	icons/actions/24/trim-margins.svg (1 line)
A	M	icons/actions/24/trim-to-selection.svg (1 line)
A	M	icons/actions/32/trim-margins.svg (1 line)
A	M	icons/actions/32/trim-to-selection.svg (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	50334	31e1b99		Jan 26 2019, 4:51 PM	★	★
Diff 2	50336	31e1b99	- Enlarge faded lines in trim-to-selection icons	Jan 26 2019, 5:17 PM	★	★
Diff 3	50337	6ea4594	R266:8b412d0fc4be98464fa6aee1d9339cee138ec2ca	Jan 26 2019, 5:11 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
ffbd01e5368a	fd5162a00652	a1603c8c7a66	Rafael Brandmaier	Enlarge faded lines in trim-to-selection icons	Jan 26 2019, 5:17 PM
a1603c8c7a66	7f9d83f7f05e	31e1b9977a47	Rafael Brandmaier	Add trim margins and trim to selection icons (Show More…)	Jan 26 2019, 4:51 PM