Add icons for the Trim Margins tools
ClosedPublic
Actions

Authored by ngraham on Aug 31 2018, 11:16 PM.

Details

Reviewers

Group Reviewers

Okular
VDG

Commits

R223:259961f6d18f: Add icons for the Trim Margins tools

Summary

New icons were added in D18552.

BUG: 397768
FIXED-IN: 19.04.0

Test Plan

Repository

R223 Okular

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: okular-devel. · View Herald Transcript

ngraham requested review of this revision.Aug 31 2018, 11:16 PM

I'm not really a fan of two consecutive entries having the same icon, but won't block this either.

Someone else likes nathan changes?

Definitely open to different icon suggestions, FWIW. I looked but couldn't find anything better.

Filed a bug requesting new icons that we can use here: https://bugs.kde.org/show_bug.cgi?id=401489

ngraham planned changes to this revision.Nov 27 2018, 11:06 PM

Use new icons added in D18552

The new icons by @trickyricky26 look great!

This revision is now accepted and ready to land.Jan 26 2019, 6:04 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			ui/pageview.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	40797	c04ca1f		Aug 31 2018, 11:16 PM	★	★
Diff 2	50338			Jan 26 2019, 5:25 PM	★	★
Diff 3	50349	f22fbca	R223:259961f6d18fde46d0faf57b18a482324e888a24	Jan 26 2019, 8:57 PM	★	★