DocManager: Don't show empty popup
Needs ReviewPublic

Authored by loh.tar on Tue, Jan 8, 7:49 PM.

Details

Reviewers
cullmann
dhaumann
mwolff
Group Reviewers
Kate
Summary

Belongs to D18116

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
loh.tar created this revision.Tue, Jan 8, 7:49 PM
Restricted Application added a project: Kate. · View Herald TranscriptTue, Jan 8, 7:49 PM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
loh.tar requested review of this revision.Tue, Jan 8, 7:49 PM

I think we should tackle that differently:

  1. we can just skip the messaging always, we have always inline messages, I think that would be ok
  2. we should just set openSuccess to false if we have an doc->openingError() and the document is empty

> that should avoid extra popups + still heal the closeOrphaned stuff (single user of openSuccess).

we can just skip the messaging always, we have always inline messages, I think that would be ok

very well, will remove that too

we should just set openSuccess to false if we have an doc->openingError() and the document is empty

I think this not sufficient. These "openingError()" is somewhere used to change the document icon. So I believe there is a need to change this to an (u)int value, 0=good, 1=someTrouble, 3=seriousProblem=orphaned

This way someone can have in a document overview a hint that at some docs is something odd. This pic is taken after a session restore. It's my own (not finished) plugin, other looks similar.

  • Here is the gone foo file in a visible view. There was also a "New File" inline message which disappear quickly [1]. So I like to fix this that this "Not Exist" message is inline and not (only) the "New File"
  • The testfile has the "to big trouble" issue.

To solve this all we need a solution in D18116/KateBuffer::openFile

[1] I had Dominik pointed D16336 that this message stuff need love, but got no response

mwolff resigned from this revision.Tue, Jan 15, 2:05 PM

I think this is not sufficient. These "openingError()" is somewhere used to change the document icon. So I believe there is a need to change this to an (u)int value, 0=good, 1=someTrouble, 3=seriousProblem=orphaned

@cullmann @dhaumann Need a "GO" for this or some other advice