Don't show document load trouble twice
Needs ReviewPublic

Authored by loh.tar on Tue, Jan 8, 7:41 PM.

Details

Reviewers
cullmann
dhaumann
Group Reviewers
KTextEditor
Summary

Since there are fancy "in view" messages which show all loading trouble
are the still existent popup dialogs redundant, hence removed

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
loh.tar created this revision.Tue, Jan 8, 7:41 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptTue, Jan 8, 7:41 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
loh.tar requested review of this revision.Tue, Jan 8, 7:41 PM

I have it only poor tested with our big S&R file, so no test was made with other trouble causing stuff.
This need a patch in Kate, will try to link that

KateBuffer::openFile

  • There is no distingues from
    1. "create new file by command line" and
    2. "restore files of session"
  • When..
    1. is the error wrong
    2. makes to me "new file" not much sense

Is there a way to check wat is going on, 1) or 2) ? Guess, yes, and you can point me

loh.tar updated this revision to Diff 50027.Mon, Jan 21, 9:34 PM
  • Don't set m_openingErrorMessage in KateBuffer::openFile
  • m_openingErrorMessage is now nowhere set

Just for info: If openingErrorMessage is indeed not set anymore, this is a behavior change, since KTextEditor::Document::openingErrorMessage() is public API. Looking at lxr.kde.org, it seems this is not used (but ->openingError() is used, see https://lxr.kde.org/source/kde/applications/kate/addons/filetree/katefiletreemodel.cpp#0554).