Since there are fancy "in view" messages which show all loading trouble,
is there no need to fetch and show some error message.
Details
- Reviewers
cullmann dhaumann mwolff - Group Reviewers
Kate - Commits
- R40:2fbda43574c0: DocManager: Don't show load trouble popup messages
Diff Detail
- Repository
- R40 Kate
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
I think we should tackle that differently:
- we can just skip the messaging always, we have always inline messages, I think that would be ok
- we should just set openSuccess to false if we have an doc->openingError() and the document is empty
> that should avoid extra popups + still heal the closeOrphaned stuff (single user of openSuccess).
we can just skip the messaging always, we have always inline messages, I think that would be ok
very well, will remove that too
we should just set openSuccess to false if we have an doc->openingError() and the document is empty
I think this not sufficient. These "openingError()" is somewhere used to change the document icon. So I believe there is a need to change this to an (u)int value, 0=good, 1=someTrouble, 3=seriousProblem=orphaned
This way someone can have in a document overview a hint that at some docs is something odd. This pic is taken after a session restore. It's my own (not finished) plugin, other looks similar.
- Here is the gone foo file in a visible view. There was also a "New File" inline message which disappear quickly [1]. So I like to fix this that this "Not Exist" message is inline and not (only) the "New File"
- The testfile has the "to big trouble" issue.
To solve this all we need a solution in D18116/KateBuffer::openFile
[1] I had Dominik pointed D16336 that this message stuff need love, but got no response
Hmm,
perhaps I am a bit confused, but if we just keep the code in ktexteditor as is (e.g. not doing D18116) but in Kate just don't show any summary dialog, we have
- orphaned ok as we set info->openSuccess = false;
- some icon in the document list (until one reloads the files successfully thanks to the item->doc()->openingError() there)
the only problem is that the notifications vanish too fast? Or do I miss an other issue if we go that way.
- if we just keep the code in ktexteditor as is
- we should just set openSuccess to false if we have an doc->openingError() and the document is empty
Um, I think that are two differend suggestions.
So, well, yes, without to change the logic in D18116 (but still apply that to remove unneded text) it work as needed.
On the other hand is it that way not "full right", for me is some overlenght or encoding warning not an "open error".
I could live with not "full right". We would get rid of the annoying popup and still have enough indication of issues in my opinion.
So, well, yes, without to change the logic in D18116 (but still apply that to remove unneded text) it work as needed.
Hm, I think I was wrong. There is the problem with these orphanet files. A really new file would be closed too.
Other question: We don't set m_openingErrorMessage anymore, so the access function Document::openingErrorMessage() becomes pointless
Hmm, but not with the
"we should just set openSuccess to false if we have an doc->openingError() and the document is empty"
change, or? Then only new files would die, but actually that would even make sense, as they are orphan, or?
- Only set "no success" when doc is empty
- Remove unneded stuff
Then only new files would die,
Currently apparently not
but actually that would even make sense, as they are orphan, or?
Hm, not what I would expect
I get the following error when applying the patch:
Applied patch kate/katedocmanager.h cleanly. Applying patch kate/katedocmanager.cpp with 2 rejects... Hunk #1 applied cleanly. Rejected hunk #2. Rejected hunk #3.
Could you rebase your patch and post an updated version here?