Differential D17938

Add support for passing cursor information to KRun.
AbandonedPublic
Actions

Authored by arrowd on Jan 3 2019, 9:35 AM.

Details

Reviewers
None
Group Reviewers
Frameworks
Summary

CCBUG: 398998

This is the KIO part of https://bugs.kde.org/show_bug.cgi?id=398998

Test Plan

With another change to kioclient5 (not submitted yet) running kioclient5 exec textfile:12:34 works fine.
Corner cases also tested.

Diff Detail

Repository
R241 KIO
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6598
Build 6616: arc lint + arc unit
arrowd created this revision.Jan 3 2019, 9:35 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 3 2019, 9:35 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
arrowd requested review of this revision.Jan 3 2019, 9:35 AM
ngraham edited the summary of this revision. (Show Details)Jan 3 2019, 8:14 PM
elvisangelaccio added a subscriber: elvisangelaccio.Jan 5 2019, 4:53 PM

I don't know, "cursorRow" and "cursorColumn" are pretty editor-specific. I'm not sure they make sense in the KRun API.

arrowd added a comment.Jan 5 2019, 5:26 PM
In D17938#386985, @elvisangelaccio wrote:

I don't know, "cursorRow" and "cursorColumn" are pretty editor-specific. I'm not sure they make sense in the KRun API.

I'd say they are both filetype-specific and service-specific. But I haven't found any other approach.

aacid added a subscriber: aacid.Jan 5 2019, 5:30 PM

Encode the information in the url?

Also this change is binary incompatible, please see the wiki https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B

elvisangelaccio added a comment.Jan 5 2019, 5:33 PM
In D17938#386999, @arrowd wrote:
In D17938#386985, @elvisangelaccio wrote:

I don't know, "cursorRow" and "cursorColumn" are pretty editor-specific. I'm not sure they make sense in the KRun API.

I'd say they are both filetype-specific and service-specific. But I haven't found any other approach.

Did you see my comment in the bug report? https://bugs.kde.org/show_bug.cgi?id=398998#c5

elvisangelaccio added a comment.Jan 15 2019, 4:04 PM

@arrowd I see you landed D18099, so this can be discarded, right?

arrowd abandoned this revision.Jan 15 2019, 4:21 PM

Right.

Revision Contents
Changeset List

PathPackages
Msrc/widgets/krun.h (13 lines)
Msrc/widgets/krun.cpp (26 lines)
Msrc/widgets/krun_p.h (2 lines)

Diff 48587

View Options

src/widgets/krun.h

Loading...
View Options

src/widgets/krun.cpp

Loading...
View Options

src/widgets/krun_p.h

Loading...