Add ability to get cursor data from URL query arguments, like file://foo.txt?line=123&column=456
ClosedPublic

Authored by arrowd on Tue, Jan 8, 3:25 PM.

Details

Summary

CCBUG: 398998

Test Plan

Opening a file with such URL works in both KWrite and Kate.

Diff Detail

Repository
R40 Kate
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
arrowd created this revision.Tue, Jan 8, 3:25 PM
Restricted Application added a project: Kate. · View Herald TranscriptTue, Jan 8, 3:25 PM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
arrowd requested review of this revision.Tue, Jan 8, 3:25 PM
mwolff accepted this revision.Tue, Jan 8, 3:26 PM
mwolff added a subscriber: mwolff.

+1, but it would be good if we could share this code...

This revision is now accepted and ready to land.Tue, Jan 8, 3:26 PM
arrowd added a comment.Tue, Jan 8, 3:29 PM

+1, but it would be good if we could share this code...

Share these two snippets or with KDevelop?

dhaumann added inline comments.
kate/kateapp.cpp
197

Please make line and column an int. It's an int in KWrite handing as well.

arrowd updated this revision to Diff 49011.Tue, Jan 8, 4:34 PM
arrowd marked an inline comment as done.

Change the type from uint to int.

Can I push this?

cullmann accepted this revision.Tue, Jan 15, 11:02 AM
cullmann added a subscriber: cullmann.

I think this can go in.
Having it shared between both apps in the urlinfo.h would be nicer, but having this feature now is better than waiting for that.

This revision was automatically updated to reflect the committed changes.

Thanks for the improvement, btw.!