Thanks! Does the code change in src/filewidgets/knewfilemenu.cpp make sense to you? I tested a bunch but I know you're the expert here. :)

Tagging is on January 5th, so I'd like to get this in before then. Any objections from anyone if I commit this?

Hmm, let me read the unittest more closely.

The scenario is: "New Folder" exists. The user asks to create a new folder, the initial suggestion in the dialog is "New Folder (1)". The user removes the (1), and hits OK, i.e. the user is asking to create "New Folder" again.
The unittest is then just checking that "New Folder" exists, which is kind of broken since it does exist anyway, since that's the initial setup.

But now you're testing that "New Folder (1)" gets created? That seems really odd, it's not what the user is asking for.

In D17911#386581, @dfaure wrote:

Hmm, let me read the unittest more closely.

The scenario is: "New Folder" exists. The user asks to create a new folder, the initial suggestion in the dialog is "New Folder (1)". The user removes the (1), and hits OK, i.e. the user is asking to create "New Folder" again.

This is now an error condition. So maybe the test should check to make sure it fails?

That makes sense. You could set expectedFileName to empty, and change the test code to interpret this as "nothing got created (and possibly: check that we got an error signal, if there's one)"