In principle this might be acceptable, but I'd like to make sure we don't regress anything like we did with the Screen Edge effect when that got turned on by default for all users (not just those with touch hardware): https://bugs.kde.org/show_bug.cgi?id=387775

I'd like to try it out, but the effect does not seem to have any effect on my system (a 2-in-1 convertible). Is this a known issue?

I've just enabled it on my laptop, will report back next week

In D17884#384306, @ngraham wrote:

In principle this might be acceptable, but I'd like to make sure we don't regress anything like we did with the Screen Edge effect when that got turned on by default for all users (not just those with touch hardware): https://bugs.kde.org/show_bug.cgi?id=387775

There is no chance that this can regress anywhere :-)

I'd like to try it out, but the effect does not seem to have any effect on my system (a 2-in-1 convertible). Is this a known issue?

You are using X11. The effect only supports Wayland.

In D17884#384439, @graesslin wrote:

I'd like to try it out, but the effect does not seem to have any effect on my system (a 2-in-1 convertible). Is this a known issue?

You are using X11. The effect only supports Wayland.

Oh ok. We should not even display it on X11 then since it gives the impression of just being broken, which doesn't make a great impression on the user.

In D17884#384500, @ngraham wrote:

Oh ok. We should not even display it on X11 then since it gives the impression of just being broken, which doesn't make a great impression on the user.

Looks like it would be a good idea to expose OperationMode enum to effects, though adjusting our tests will be probably(not sure) a little bit painful.

In D17884#384500, @ngraham wrote:

In D17884#384439, @graesslin wrote:

I'd like to try it out, but the effect does not seem to have any effect on my system (a 2-in-1 convertible). Is this a known issue?

You are using X11. The effect only supports Wayland.

Oh ok. We should not even display it on X11 then since it gives the impression of just being broken, which doesn't make a great impression on the user.

It had been like that for several years and nobody cares so far. Let's not make a fuzz about nothing.

In D17884#384535, @graesslin wrote:

In D17884#384500, @ngraham wrote:

In D17884#384439, @graesslin wrote:

I'd like to try it out, but the effect does not seem to have any effect on my system (a 2-in-1 convertible). Is this a known issue?

You are using X11. The effect only supports Wayland.

Oh ok. We should not even display it on X11 then since it gives the impression of just being broken, which doesn't make a great impression on the user.

It had been like that for several years and nobody cares so far. Let's not make a fuzz about nothing.

Well it used to cause Latte to break a few months ago but they fixed it.
Considering that it doesn't work, I think it should be disabled and unavailable in the menu (or removed entirely).

In D17884#386601, @rooty wrote:

Well it used to cause Latte to break a few months ago but they fixed it.
Considering that it doesn't work, I think it should be disabled and unavailable in the menu (or removed entirely).

Hiding it on X11 is out of scope of this revision.

In D17884#386601, @rooty wrote:

In D17884#384535, @graesslin wrote:

In D17884#384500, @ngraham wrote:

In D17884#384439, @graesslin wrote:

I'd like to try it out, but the effect does not seem to have any effect on my system (a 2-in-1 convertible). Is this a known issue?

You are using X11. The effect only supports Wayland.

Oh ok. We should not even display it on X11 then since it gives the impression of just being broken, which doesn't make a great impression on the user.

It had been like that for several years and nobody cares so far. Let's not make a fuzz about nothing.

Well it used to cause Latte to break a few months ago but they fixed it.
Considering that it doesn't work, I think it should be disabled and unavailable in the menu (or removed entirely).

It's absolutely impossible that this effect broke anything. I think you are mixing up things.

+100 from me

If there are no objections I would push it, so that we have it in the upcoming beta.

I used this for a week, and tried to poke my laptop screen more.

It didn't bother me, but I can't say I really gained anything as my finger was always in the way of the small circle.

So from my POV, whatever.

In D17884#389993, @davidedmundson wrote:

I used this for a week, and tried to poke my laptop screen more.

It didn't bother me, but I can't say I really gained anything as my finger was always in the way of the small circle.

Might be a hint that we need to increase the circles. You use scaling, don't you? Looking at the code we seem to hard code the max ring size and don't add any dpi information.

scaling,

I do but it shouldn't be the issue, the Wayland resizing is all done in the glViewport/QPainter viewport it should be bigger in pixels automagically.

I've tried this effect and in general it looks okay to me. The only thing that I don't like is the default color palette but that's probably matter of personal taste.

Also, I believe we could improve visuals of this effect by making finger trails and ripples more smoother. The only problem is that we don't have any good API to draw arbitrary shapes on the screen in libkwineffects.

+1