Differential D17357

extend list of supported mimetypes for embedded image extractor
ClosedPublic
Actions

Authored by astippich on Dec 4 2018, 7:27 PM.

Details

Reviewers
bruns
mgallien
Commits
R286:9f67b436f851: extend list of supported mimetypes for embedded image extractor
Summary

use existing functions to add support for new
mimetypes wav, aiff, ape, wavpack and speex

Test Plan

tests pass

Diff Detail

Repository
R286 KFileMetaData
Branch
image_extend
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5701
Build 5719: arc lint + arc unit
astippich created this revision.Dec 4 2018, 7:27 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptDec 4 2018, 7:27 PM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
astippich requested review of this revision.Dec 4 2018, 7:27 PM
bruns accepted this revision.Dec 4 2018, 11:38 PM

Can you mention the file types and their corresponding mimetypes in the Summary? Thx.

src/embeddedimagedata.cpp
199

Comment about tag->isEmpty() from D16671 applies here as well

This revision is now accepted and ready to land.Dec 4 2018, 11:38 PM
astippich edited the summary of this revision. (Show Details)Dec 6 2018, 6:09 PM
Closed by commit R286:9f67b436f851: extend list of supported mimetypes for embedded image extractor (authored by astippich). · Explain WhyDec 6 2018, 6:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 46861

View Options

autotests/embeddedimagedatatest.cpp

Loading...
View Options

autotests/samplefiles/test.spx

Loading...
View Options

src/embeddedimagedata.cpp

Loading...